ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 22206: Views: Add <description> to view instance & Provide <visible> property on view instance
Date Tue, 03 Jun 2014 19:16:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22206/
-----------------------------------------------------------

(Updated June 3, 2014, 7:16 p.m.)


Review request for Ambari, Sumit Mohanty and Sid Wagle.


Changes
-------

Include changes for AMBARI-6013


Summary (updated)
-----------------

Views: Add <description> to view instance &  Provide <visible> property on
view instance


Bugs: AMBARI-6006 and AMBARI-6013
    https://issues.apache.org/jira/browse/AMBARI-6006
    https://issues.apache.org/jira/browse/AMBARI-6013


Repository: ambari


Description (updated)
-------

Add a <description> property to view instances.

----

On a given instance, provide ability to set <visible> property.

When set to false, the UI should not display this View instance in the UI (like in the dropdown
list, or in the future Views management tab (i.e. a section of Ambari Web where an end user
can see the list of Views he has installed).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
af3a549 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
a4900e6 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java fa1861a

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 966f50a 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java
95441c6 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 67fb846 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5ec05fd 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 72ed1eb 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c2440ce 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java
a6653cc 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
9904c0c 
  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java
a10f321 
  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
74f48a8 
  ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 5b9b92d 

Diff: https://reviews.apache.org/r/22206/diff/


Testing (updated)
-------

Results :

Tests run: 1651, Failures: 0, Errors: 0, Skipped: 13

…

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:02.011s
[INFO] Finished at: Tue Jun 03 12:38:45 EDT 2014
[INFO] Final Memory: 37M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message