ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 22208: Incorrect behaviour when trying to execute upgradestack to nonexistent HDP version
Date Tue, 03 Jun 2014 15:44:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/#review44630
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
<https://reviews.apache.org/r/22208/#comment79045>

    This change will not have proper behavior for stacks other than HDP.  It's not guaranteed
of a .repo file at that location, nor that it will be named with these assumptions.  Also
HEAD may not be served either.


- Nate Cole


On June 3, 2014, 11:32 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22208/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 11:32 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-6008
>     https://issues.apache.org/jira/browse/AMBARI-6008
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
>     [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
>     Using python  /usr/bin/python2.6
>     Upgrading stack of ambari-server
>     WARNING: could not change directory to "/root"
>     
>     Ambari Server 'upgradestack' completed successfully.
>     
> 
> Ambari should consider the validity of the data if was specified the invalid
> HDP version and give the correct message about this.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
77ec069 
>   ambari-server/src/main/python/ambari-server.py 6ad94d5 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java
PRE-CREATION 
>   ambari-server/src/test/python/TestAmbariServer.py c2d868d 
> 
> Diff: https://reviews.apache.org/r/22208/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message