Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 12EE1109F4 for ; Thu, 29 May 2014 01:07:19 +0000 (UTC) Received: (qmail 18908 invoked by uid 500); 29 May 2014 01:00:39 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 18888 invoked by uid 500); 29 May 2014 01:00:39 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 18874 invoked by uid 99); 29 May 2014 01:00:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 May 2014 01:00:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0D0BC1D98BE; Thu, 29 May 2014 01:00:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6960131873447485893==" MIME-Version: 1.0 Subject: Review Request 21999: Predicates don't work on fields with float values From: "Sid Wagle" To: "Mahadev Konar" , "Tom Beerbower" Cc: "Sid Wagle" , "Ambari" Date: Thu, 29 May 2014 01:00:30 -0000 Message-ID: <20140529010030.12585.75448@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/21999/ X-Sender: "Sid Wagle" Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============6960131873447485893== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21999/ ----------------------------------------------------------- Review request for Ambari, Mahadev Konar and Tom Beerbower. Bugs: AMBARI-5922 https://issues.apache.org/jira/browse/AMBARI-5922 Repository: ambari Description ------- API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one. Currently the Greater than predicate will fail for values in between 0.0 and 1.0 Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6 ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff Diff: https://reviews.apache.org/r/21999/diff/ Testing ------- Thanks, Sid Wagle --===============6960131873447485893==--