Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 935B910C87 for ; Wed, 28 May 2014 16:33:03 +0000 (UTC) Received: (qmail 45740 invoked by uid 500); 28 May 2014 16:33:03 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 45714 invoked by uid 500); 28 May 2014 16:33:03 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 45704 invoked by uid 99); 28 May 2014 16:33:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 May 2014 16:33:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C41461D5EA5; Wed, 28 May 2014 16:32:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6901402486934173746==" MIME-Version: 1.0 Subject: Review Request 21982: OS constants should be located in one place From: "Dmytro Sen" To: "Andrew Onischuk" Cc: "Dmytro Sen" , "Ambari" Date: Wed, 28 May 2014 16:32:53 -0000 Message-ID: <20140528163253.12585.1407@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/21982/ X-Sender: "Dmytro Sen" Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============6901402486934173746== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21982/ ----------------------------------------------------------- Review request for Ambari and Andrew Onischuk. Bugs: AMBARI-5911 https://issues.apache.org/jira/browse/AMBARI-5911 Repository: ambari Description ------- OS constants are defined in several places like HostInfo.py in agent, utils.py in server. Definition of constants should be moved to os_check.py to avoid possibly difference between constants in HostInfo.py and utils.py. HostInfo.py OS_UBUNTU_DEBIAN = 'debian' OS_UBUNTU = 'ubuntu' OS_FEDORA = 'fedora' OS_OPENSUSE = 'opensuse' OS_SUSE = 'suse' OS_SUSE_ENTERPRISE = 'sles' utils.py OS_UBUNTU = 'ubuntu' OS_FEDORA = 'fedora' OS_OPENSUSE = 'opensuse' OS_SUSE = 'suse' OS_SUSE_ENTERPRISE = 'sles' Diffs ----- ambari-agent/src/main/python/ambari_agent/HostInfo.py 1e74dea ambari-common/src/main/python/common_functions/__init__.py 50baaba ambari-common/src/main/python/common_functions/os_check.py 79aaa75 ambari-server/src/main/python/ambari-server.py 81dadbd ambari-server/src/main/python/ambari_server/utils.py c132f50 ambari-server/src/main/python/bootstrap.py 650751f ambari-server/src/test/python/TestOSCheck.py f420095 Diff: https://reviews.apache.org/r/21982/diff/ Testing ------- Thanks, Dmytro Sen --===============6901402486934173746==--