Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2581A11369 for ; Fri, 23 May 2014 11:57:06 +0000 (UTC) Received: (qmail 89225 invoked by uid 500); 23 May 2014 11:57:06 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 89194 invoked by uid 500); 23 May 2014 11:57:06 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 89184 invoked by uid 99); 23 May 2014 11:57:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2014 11:57:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4B7BD1D963E; Fri, 23 May 2014 11:56:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7852376520772926467==" MIME-Version: 1.0 Subject: Re: Review Request 21856: Add unit tests for views/*.js files From: "Aleksandr Kovalenko" To: "Aleksandr Kovalenko" Cc: "Alexandr Antonenko" , "Ambari" Date: Fri, 23 May 2014 11:56:58 -0000 Message-ID: <20140523115658.8064.17237@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aleksandr Kovalenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/21856/ X-Sender: "Aleksandr Kovalenko" References: <20140523115616.29379.12085@reviews.apache.org> In-Reply-To: <20140523115616.29379.12085@reviews.apache.org> Reply-To: "Aleksandr Kovalenko" X-ReviewRequest-Repository: ambari --===============7852376520772926467== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21856/#review43823 ----------------------------------------------------------- Ship it! Ship It! - Aleksandr Kovalenko On May 23, 2014, 11:56 a.m., Alexandr Antonenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21856/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 11:56 a.m.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-5867 > https://issues.apache.org/jira/browse/AMBARI-5867 > > > Repository: ambari > > > Description > ------- > > Add unit tests for views/*.js files > > > Diffs > ----- > > ambari-web/app/assets/test/tests.js 2db199d > ambari-web/app/views/experimental.js 5d84c2c > ambari-web/test/views/application_test.js PRE-CREATION > ambari-web/test/views/experimental_test.js PRE-CREATION > ambari-web/test/views/installer_test.js PRE-CREATION > ambari-web/test/views/login_test.js PRE-CREATION > > Diff: https://reviews.apache.org/r/21856/diff/ > > > Testing > ------- > > > Thanks, > > Alexandr Antonenko > > --===============7852376520772926467==--