Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============2866005768755225677=="
MIME-Version: 1.0
Subject: Re: Review Request 21636: Create a different global for hive heapsize
 ->
 hive_heapsize for hive-env.sh.
From: "Oleg Nechiporenko" <onechiporenko@apache.org>
To: "Mahadev Konar" <mahadev@apache.org>,
 "Oleg Nechiporenko" <onechiporenko@apache.org>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
Cc: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Wed, 21 May 2014 15:46:59 -0000
Message-ID: <20140521154659.21124.89690@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Oleg Nechiporenko" <noreply@reviews.apache.org>
References: <20140521153708.21124.70328@reviews.apache.org>
In-Reply-To: <20140521153708.21124.70328@reviews.apache.org>
Reply-To: "Oleg Nechiporenko" <onechiporenko@apache.org>

--===============2866005768755225677==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21636/#review43627
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On May 21, 2014, 3:37 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21636/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 3:37 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Mahadev Konar, and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-5768
>     https://issues.apache.org/jira/browse/AMBARI-5768
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a different glocal for hive heapsize -> hive_heapsize for hive-env.sh.
> 
> https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=blob_plain;f=ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/hive-env.sh.j2;hb=HEAD
> 
> Uses:
> 
> {code}
> export HADOOP_HEAPSIZE="{{hadoop_heapsize}}"
> export HADOOP_CLIENT_OPTS="-Xmx${HADOOP_HEAPSIZE}m $HADOOP_CLIENT_OPTS"
> {code}
> 
> We should have a different global/parameter for this -> hive_heapsize in Hive service page.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 4a42ea4 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 1f21780 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/templates/hive-env.sh.j2 b2da231 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 7e026bd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 96b0e45 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/hive-env.sh.j2 4e93443 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 37d6554 
>   ambari-web/app/data/HDP2/site_properties.js bbdbfcd 
>   ambari-web/app/data/service_configs.js eee95ce 
>   ambari-web/app/data/site_properties.js f487c3e 
> 
> Diff: https://reviews.apache.org/r/21636/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


--===============2866005768755225677==--