Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 772EA11F1E for ; Mon, 19 May 2014 17:05:55 +0000 (UTC) Received: (qmail 1977 invoked by uid 500); 19 May 2014 17:05:55 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 1950 invoked by uid 500); 19 May 2014 17:05:55 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 1939 invoked by uid 99); 19 May 2014 17:05:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 May 2014 17:05:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AF5781D9009; Mon, 19 May 2014 17:05:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1765110500604463696==" MIME-Version: 1.0 Subject: Re: Review Request 21566: Agent function get_port_from_url is broken From: "Dmytro Sen" To: "Dmytro Sen" Cc: "Andrew Onischuk" , "Ambari" Date: Mon, 19 May 2014 17:05:47 -0000 Message-ID: <20140519170547.3715.8797@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/21566/ X-Sender: "Dmytro Sen" References: <20140519161518.3715.4048@reviews.apache.org> In-Reply-To: <20140519161518.3715.4048@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============1765110500604463696== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21566/#review43370 ----------------------------------------------------------- Ship it! Ship It! - Dmytro Sen On May 19, 2014, 4:15 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21566/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 4:15 p.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-5797 > https://issues.apache.org/jira/browse/AMBARI-5797 > > > Repository: ambari > > > Description > ------- > > Pre-1.6.1 had a a function get_port_from_url that was working. In 1.6.1 this > is broken: > > 1.6.1: uses urlparse function which does not work with a definition like so: > 0.0.0.0:12345 > > 1.6.0: (correctly) uses address.split(':')[-1] > > > Diffs > ----- > > ambari-agent/src/main/python/resource_management/libraries/functions/get_port_from_url.py ce9185b > ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py PRE-CREATION > ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json ce92689 > ambari-server/src/test/python/stacks/1.3.2/configs/default.json 8eabd30 > ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json d9b928d > ambari-server/src/test/python/stacks/1.3.2/configs/secured.json fe3d6f6 > ambari-server/src/test/python/stacks/1.3.2/configs/secured_no_jce_name.json 105d0b7 > ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 4817a58 > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 3f5220e > ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json b30714c > ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 931f202 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_default.json 0ea0db3 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_secured.json dce20fa > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 12de853 > ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json ecf5031 > ambari-server/src/test/python/stacks/2.1/configs/default.json fdac02a > ambari-server/src/test/python/stacks/2.1/configs/secured.json 8e76ef5 > > Diff: https://reviews.apache.org/r/21566/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > > --===============1765110500604463696==--