Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D9253110E6 for ; Mon, 19 May 2014 13:57:30 +0000 (UTC) Received: (qmail 64395 invoked by uid 500); 19 May 2014 13:57:30 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 64365 invoked by uid 500); 19 May 2014 13:57:30 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 64356 invoked by uid 99); 19 May 2014 13:57:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 May 2014 13:57:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3A8B31D8FE2; Mon, 19 May 2014 13:57:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4565954306279802368==" MIME-Version: 1.0 Subject: Re: Review Request 21632: Views: Pig view parameters adjusting From: "Tom Beerbower" To: "Tom Beerbower" Cc: "Ambari" Date: Mon, 19 May 2014 13:57:21 -0000 Message-ID: <20140519135721.18046.52309@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/21632/ X-Sender: "Tom Beerbower" References: <20140519134424.19094.90231@reviews.apache.org> In-Reply-To: <20140519134424.19094.90231@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============4565954306279802368== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21632/ ----------------------------------------------------------- (Updated May 19, 2014, 1:57 p.m.) Review request for Ambari and Tom Beerbower. Bugs: AMBARI-5786 https://issues.apache.org/jira/browse/AMBARI-5786 Repository: ambari Description ------- 1) Rename dataworker.hdfs_user -> dataworker.hdfs.username Use this as HDFS user (if provided) 2) Remove dataworker.use_current_user parameter 3) Add dataworker.username and use it in generating paths for scripts and jobs status directories (if not provided then use context.getUsername()) 4) Rename dataworker.templeton_url -> dataworker.webhcat.url and dataworker.templeton_user -> dataworker.webhcat.user Diffs ----- contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/PersonalCRUDResourceManager.java 650d9a2 contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java abc2ddd contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptResourceManager.java f98bdab contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/BaseService.java 06e00c2 contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/TempletonApi.java 4fe61cd contrib/views/pig/src/main/resources/view.xml dd10198 contrib/views/pig/src/test/java/org/apache/ambari/view/pig/BasePigTest.java 7352157 contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 6cf4bd7 contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTest.java e7ddf3d contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestHDFSUnmanaged.java 9eacbee contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestUnmanaged.java a6138b5 Diff: https://reviews.apache.org/r/21632/diff/ Testing (updated) ------- New unit tests. All view tests pass... [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Ambari Contrib Views .............................. SUCCESS [1.574s] [INFO] Files ............................................. SUCCESS [2:01.523s] [INFO] Pig ............................................... SUCCESS [1:04.320s] [INFO] Slider ............................................ SUCCESS [1:44.496s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4:53.621s [INFO] Finished at: Mon May 19 09:55:30 EDT 2014 [INFO] Final Memory: 28M/81M [INFO] ------------------------------------------------------------------------ Thanks, Tom Beerbower --===============4565954306279802368==--