Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1376A10F41 for ; Mon, 12 May 2014 10:49:38 +0000 (UTC) Received: (qmail 41452 invoked by uid 500); 12 May 2014 10:49:37 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 41420 invoked by uid 500); 12 May 2014 10:49:37 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 41410 invoked by uid 99); 12 May 2014 10:49:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 May 2014 10:49:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D866C1D54E6; Mon, 12 May 2014 10:49:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4766615087503126346==" MIME-Version: 1.0 Subject: Re: Review Request 21317: Decommission issues in secure cluster. From: "Andrew Onischuk" To: "Vitalyi Brodetskyi" Cc: "Andrew Onischuk" , "Ambari" Date: Mon, 12 May 2014 10:49:30 -0000 Message-ID: <20140512104930.5509.21959@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrew Onischuk" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/21317/ X-Sender: "Andrew Onischuk" References: <20140512104600.16543.7658@reviews.apache.org> In-Reply-To: <20140512104600.16543.7658@reviews.apache.org> Reply-To: "Andrew Onischuk" X-ReviewRequest-Repository: ambari --===============4766615087503126346== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21317/ ----------------------------------------------------------- (Updated May 12, 2014, 10:49 a.m.) Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-5729 https://issues.apache.org/jira/browse/AMBARI-5729 Repository: ambari Description (updated) ------- Yarn package params.py file references to `nodemanager_principal_name` and `nodemanager_keytab` properties. There are 3 issues over here: 1. Ideally, Ambari agent should not access and so not even refer to any service principal name. 2. If required, Ambari agent should use yarn-site properties to fetch service principal name and keytab path instead of using global properties. 3. In the resourcemanager.py decomission action, Yarn user kinit's using nodemanager principal. Decommission action is always executed on resourcemanager host and so we should atleast use resource manager principal (as it is guaranteed to be on that host). **As of now in a secure cluster if NodeManager is not present on ResourceManager host then NodeManager decomissioning won't work (due to unavailability of NodeManager keytab)** Also ambari-agent **does not kinit before executing DataNode decommission command**. If an API request for decommissioning is made after hdfs user kerberos ticket has expired then the request will fail due to kerberos exception. Diffs ----- ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py e7ed33b ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 7bc8ca7 ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 065467c ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 6e6b34f Diff: https://reviews.apache.org/r/21317/diff/ Testing ------- mvn clean test Thanks, Andrew Onischuk --===============4766615087503126346==--