Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5281375362621307564=="
MIME-Version: 1.0
Subject: Re: Review Request 21116: iptables host check warning shows on centos
 5.9
 even if iptables are stopped
From: "Nate Cole" <ncole@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>, "Dmytro Sen" <dsen@hortonworks.com>
Cc: "Jonathan Hurley" <jhurley@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Tue, 06 May 2014 17:16:41 -0000
Message-ID: <20140506171641.25779.96147@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20140506160818.1482.1499@reviews.apache.org>
In-Reply-To: <20140506160818.1482.1499@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>

--===============5281375362621307564==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21116/#review42313
-----------------------------------------------------------


ambari-agent/src/main/python/ambari_agent/HostInfo.py
<https://reviews.apache.org/r/21116/#comment76079>

    Suse doesn't like this:
    suse1101:~ # service iptables status
    service: no such service iptables
    
    This command will be indeterminate on that platform.


- Nate Cole


On May 6, 2014, 12:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21116/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 12:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Nate Cole.
> 
> 
> Bugs: AMBARI-5686
>     https://issues.apache.org/jira/browse/AMBARI-5686
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The iptables check in the Agent was done by spawning a new process for iptables and checking the result against a pre-determined string value. This did not work on CentOS 5.x as the string values were different and the -S option was not available. Instead, we are now using the return code from the "service" command to determine the state of iptables.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 8e0cf90 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 627261d 
> 
> Diff: https://reviews.apache.org/r/21116/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 304 tests in 3.968s
> 
> OK
> [INFO] 
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/examples/*
> [INFO] Exclude: src/test/python/dummy*.txt
> [INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
> [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
> [INFO] Exclude: src/main/python/ambari_agent/imports.txt
> [INFO] Exclude: src/main/puppet/modules/stdlib/**
> [INFO] Exclude: **/*.erb
> [INFO] Exclude: **/*.json
> [INFO] 548 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 407 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.073s
> [INFO] Finished at: Tue May 06 11:55:02 EDT 2014
> [INFO] Final Memory: 7M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============5281375362621307564==--