Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9069711659 for ; Mon, 5 May 2014 19:18:27 +0000 (UTC) Received: (qmail 1935 invoked by uid 500); 5 May 2014 19:18:27 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 1914 invoked by uid 500); 5 May 2014 19:18:26 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 1901 invoked by uid 99); 5 May 2014 19:18:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 May 2014 19:18:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3ABA31D752B; Mon, 5 May 2014 19:18:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7196218177792920570==" MIME-Version: 1.0 Subject: Re: Review Request 20730: Introduce operation_level request parameter From: "Nate Cole" To: "Sid Wagle" , "Nate Cole" , "Sumit Mohanty" , "Vitalyi Brodetskyi" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Mon, 05 May 2014 19:18:19 -0000 Message-ID: <20140505191819.7613.88133@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/20730/ X-Sender: "Nate Cole" References: <20140505174449.7615.3199@reviews.apache.org> In-Reply-To: <20140505174449.7615.3199@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============7196218177792920570== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20730/#review42182 ----------------------------------------------------------- ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java Maybe this can be a case statement on Resource.InternalType ? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java What is the purpose of keeping these with the level? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java Can a operation level be inferred from the resourceFilter if there is one? Is there a relationship that can be exploited? Seems odd to have a operational level that does also apply to a resourceFilter - Nate Cole On May 5, 2014, 1:44 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20730/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 1:44 p.m.) > > > Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-5580 > https://issues.apache.org/jira/browse/AMBARI-5580 > > > Repository: ambari > > > Description > ------- > > Add Requests/operation_level property support and support of subproperties. Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from the list of available values, because it seems to be identical to SERVICE level. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076 > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b > ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java 3443b72 > ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java aefcb52 > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 37a404f > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 89eaa40 > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69 > ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 3b5afcd > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 23583b5 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 36def40 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java 14f0d55 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java e7098d2 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java fb4a87a > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579 > ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2 > ambari-server/src/main/resources/properties.json f92d238 > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 5ad1e77 > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ff3f08a > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java PRE-CREATION > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c0ad8ce > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 062338b > > Diff: https://reviews.apache.org/r/20730/diff/ > > > Testing > ------- > > I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that). > Result of unit test run attached. > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34 licence. > [INFO] ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [2.200s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s] > [INFO] Ambari Web ........................................ SUCCESS [6.233s] > [INFO] Ambari Views ...................................... SUCCESS [1.822s] > [INFO] Ambari Server ..................................... SUCCESS [12:57.429s] > [INFO] Ambari Agent ...................................... SUCCESS [5.038s] > [INFO] Ambari Client ..................................... SUCCESS [0.360s] > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 13:13.873s > [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014 > [INFO] Final Memory: 31M/360M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > > --===============7196218177792920570==--