Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 03ACC11B39 for ; Fri, 2 May 2014 04:47:12 +0000 (UTC) Received: (qmail 29883 invoked by uid 500); 2 May 2014 04:47:11 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 29748 invoked by uid 500); 2 May 2014 04:47:09 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 29118 invoked by uid 99); 2 May 2014 04:47:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 May 2014 04:47:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 910001D7410; Fri, 2 May 2014 04:46:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2149097167226181437==" MIME-Version: 1.0 Subject: Re: Review Request 20948: This creates a new HDFS file browser View (Files), front end and back end From: "Yusaku Sako" To: "Yusaku Sako" , "Tom Beerbower" Cc: "Erik Bergenholtz" , "Ambari" Date: Fri, 02 May 2014 04:46:57 -0000 Message-ID: <20140502044657.16690.17840@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yusaku Sako" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/20948/ X-Sender: "Yusaku Sako" References: <20140502043233.16690.44538@reviews.apache.org> In-Reply-To: <20140502043233.16690.44538@reviews.apache.org> Reply-To: "Yusaku Sako" X-ReviewRequest-Repository: ambari --===============2149097167226181437== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On May 2, 2014, 4:32 a.m., Yusaku Sako wrote: > > Reviewed the frontend code. > > Looks good. > > Please upload all the binary artifacts to https://issues.apache.org/jira/browse/AMBARI-5617. Actually, rat check fails. Please run "mvn apache-rat:check" to make sure it passes (for .json and .svg, add to the exclusion list). I saw errors for the following files. src/assembly/assembly.xml src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg src/main/resources/ui/bin src/main/resources/ui/bower.json src/main/resources/ui/generators/collection/generator.json src/main/resources/ui/generators/controller/generator.json src/main/resources/ui/generators/model/generator.json src/main/resources/ui/generators/route/generator.json src/main/resources/ui/generators/template/generator.json src/main/resources/ui/generators/view/generator.json src/main/resources/ui/package.json src/main/resources/ui/test/spec.coffee - Yusaku ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20948/#review42007 ----------------------------------------------------------- On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20948/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 1:52 p.m.) > > > Review request for Ambari, Tom Beerbower and Yusaku Sako. > > > Bugs: AMBARI-5617 > https://issues.apache.org/jira/browse/AMBARI-5617 > > > Repository: ambari > > > Description > ------- > > The code submission provides the implementation for a new Ambari View for File Browsing called Files; allowing for browsing and file manipulation of HDFS. > > > Diffs > ----- > > contrib/views/files/pom.xml PRE-CREATION > contrib/views/files/src/assembly/assembly.xml PRE-CREATION > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java PRE-CREATION > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java PRE-CREATION > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java PRE-CREATION > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java PRE-CREATION > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java PRE-CREATION > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java PRE-CREATION > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java PRE-CREATION > contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION > contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/index.html PRE-CREATION > contrib/views/files/src/main/resources/ui/app/components/contextMenu.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/components/uploader.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/controllers/file.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/controllers/files.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/styles/application.less PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/application.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/error.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/files.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/index.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION > contrib/views/files/src/main/resources/ui/bin PRE-CREATION > contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION > contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/collection/generator.json PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/controller/generator.json PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/model/generator.json PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/route/generator.json PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/template/generator.json PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/view/generator.json PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs PRE-CREATION > contrib/views/files/src/main/resources/ui/package.json PRE-CREATION > contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION > contrib/views/files/src/main/resources/view.xml PRE-CREATION > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java PRE-CREATION > contrib/views/pom.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/20948/diff/ > > > Testing > ------- > > The code submission includes unit tests which all execute successfully. > > > Thanks, > > Erik Bergenholtz > > --===============2149097167226181437==--