Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C2FF11F9E for ; Thu, 1 May 2014 14:52:45 +0000 (UTC) Received: (qmail 87715 invoked by uid 500); 1 May 2014 14:52:45 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 87655 invoked by uid 500); 1 May 2014 14:52:44 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 87638 invoked by uid 99); 1 May 2014 14:52:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 May 2014 14:52:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CC0051D3CB8; Thu, 1 May 2014 14:52:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5219729862610229052==" MIME-Version: 1.0 Subject: Review Request 20949: Provide basic validation of fields for blueprint create api From: "John Speidel" To: "Nate Cole" , "Sid Wagle" , "Tom Beerbower" Cc: "Ambari" , "John Speidel" Date: Thu, 01 May 2014 14:52:37 -0000 Message-ID: <20140501145237.16690.49711@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Speidel" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/20949/ X-Sender: "John Speidel" Reply-To: "John Speidel" X-ReviewRequest-Repository: ambari --===============5219729862610229052== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20949/ ----------------------------------------------------------- Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower. Bugs: AMBARI-5648 https://issues.apache.org/jira/browse/AMBARI-5648 Repository: ambari Description ------- This task is for non topology related validation of blueprint create api calls. The following validations are included: no blueprint name no host groups no host group name no host group components component specified with no name invalid component name for stack no/invalid stack name no/invalid stack version Validation failures result in a 400 response with a descriptive message of the problem. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java cdb7fea ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 Diff: https://reviews.apache.org/r/20949/diff/ Testing ------- Manual Functional Tests: Tested that appropriate responses were returned for invalid requests. Unit Tests: - Added new tests - All unit tests pass Results : Tests run: 1581, Failures: 0, Errors: 0, Skipped: 9 ... Total run:548 Total errors:0 Total failures:0 ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 17:35.082s [INFO] Finished at: Wed Apr 30 20:53:29 EDT 2014 [INFO] Final Memory: 20M/123M [INFO] ------------------------------------------------------------------------ Thanks, John Speidel --===============5219729862610229052==--