ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 22088: Views: Add <label> to <instance>
Date Fri, 30 May 2014 17:14:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22088/#review44381
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On May 30, 2014, 1:12 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22088/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 1:12 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-5970
>     https://issues.apache.org/jira/browse/AMBARI-5970
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Add <label> tag to <instance> so admins can set the visible label for a given
instance.
> 
> This is not a required tag. If not present, label from the <view> will be used.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
49298b0 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
0faf411 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java
2155ce6 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java bc193a4

>   ambari-server/src/main/java/org/apache/ambari/server/view/configuration/InstanceConfig.java
4b0c085 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de5a8ed 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql eec4a3a 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 330c1fb 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2418332 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java
b8cb7f4 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
b45e266 
>   ambari-server/src/test/java/org/apache/ambari/server/view/configuration/InstanceConfigTest.java
4f49425 
>   ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
c44e40b 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 58f40b0

> 
> Diff: https://reviews.apache.org/r/22088/diff/
> 
> 
> Testing
> -------
> 
> New unit tests added.  All existing tests pass ...
> 
> Results :
> 
> Tests run: 1637, Failures: 0, Errors: 0, Skipped: 13
> 
> ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:46.553s
> [INFO] Finished at: Fri May 30 12:43:53 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message