ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 22084: Optimize Nagios alert processing for 2K cluster
Date Fri, 30 May 2014 15:48:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22084/
-----------------------------------------------------------

(Updated May 30, 2014, 11:48 a.m.)


Review request for Ambari, Mahadev Konar and Sid Wagle.


Bugs: AMBARI-5958
    https://issues.apache.org/jira/browse/AMBARI-5958


Repository: ambari


Description
-------

* Change the code that splits a section of the file to split on key/value boundaries instead
of newline boundaries.  This cuts down on the amount of processing tremendously.
* Used xdebug + webgrind to verify functionality and method cost.


Diffs
-----

  contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8b9ccae 

Diff: https://reviews.apache.org/r/22084/diff/


Testing
-------

Manual verification of data returned on large deployment.  No automated tests for contrib
php.


Thanks,

Nate Cole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message