ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 21982: OS constants should be located in one place
Date Fri, 30 May 2014 14:21:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21982/
-----------------------------------------------------------

(Updated May 30, 2014, 2:21 p.m.)


Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-5911
    https://issues.apache.org/jira/browse/AMBARI-5911


Repository: ambari


Description
-------

OS constants are defined in several places like HostInfo.py in agent, utils.py in server.
Definition of constants should be moved to os_check.py to avoid possibly difference between
constants in HostInfo.py and utils.py.
HostInfo.py
OS_UBUNTU_DEBIAN = 'debian'
OS_UBUNTU = 'ubuntu'
OS_FEDORA = 'fedora'
OS_OPENSUSE = 'opensuse'
OS_SUSE = 'suse'
OS_SUSE_ENTERPRISE = 'sles'
utils.py
OS_UBUNTU = 'ubuntu'
OS_FEDORA = 'fedora'
OS_OPENSUSE = 'opensuse'
OS_SUSE = 'suse'
OS_SUSE_ENTERPRISE = 'sles'


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/HostInfo.py 1e74dea 
  ambari-common/src/main/python/common_functions/__init__.py 50baaba 
  ambari-common/src/main/python/common_functions/os_check.py 79aaa75 
  ambari-server/src/main/python/ambari-server.py 81dadbd 
  ambari-server/src/main/python/ambari_server/utils.py c132f50 
  ambari-server/src/main/python/bootstrap.py 650751f 
  ambari-server/src/test/python/TestOSCheck.py f420095 

Diff: https://reviews.apache.org/r/21982/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [6.573s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.380s]
[INFO] Ambari Web ........................................ SUCCESS [17.966s]
[INFO] Ambari Views ...................................... SUCCESS [2.764s]
[INFO] Ambari Server ..................................... SUCCESS [14:29.005s]
[INFO] Ambari Agent ...................................... SUCCESS [6.508s]
[INFO] Ambari Client ..................................... SUCCESS [0.730s]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [6.573s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.380s]
[INFO] Ambari Web ........................................ SUCCESS [17.966s]
[INFO] Ambari Views ...................................... SUCCESS [2.764s]
[INFO] Ambari Server ..................................... SUCCESS [14:29.005s]
[INFO] Ambari Agent ...................................... SUCCESS [6.508s]
[INFO] Ambari Client ..................................... SUCCESS [0.730s]


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message