ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 22071: Views: instancedata should be ambari user scoped
Date Fri, 30 May 2014 04:55:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22071/#review44331
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On May 30, 2014, 4 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22071/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 4 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-5953
>     https://issues.apache.org/jira/browse/AMBARI-5953
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently, instancedata is scoped to instance version. Once we have multiple users using
the same instances, the instance data should be scope by user. The framework should handle
this.
> 
> CURRENT:
>  view_name | view_instance_name | name | value 
> -----------+--------------------+------+-------
> 
> FILES{0.1.0} | FILES_1 | color | blue
> 
> This means all people who access FILES_1 get the color blue.
> 
> The framework should scope the instance data to the user, and this should be transparent
when the view puts/gets/removes instance data.
> 
>  view_name | view_instance_name | username | name | value 
> -----------+--------------------+------+-------
> 
> FILES{0.1.0} | FILES_1 | admin | color | blue
> FILES{0.1.0} | FILES_1 | pramod | color | green
> FILES{0.1.0} | FILES_1 | tom | color | red
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceDataEntity.java
5bb003d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceDataEntityPK.java
fb7ac4e 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
70a60b9 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java
e9855b8 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java f952d61

>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bfe1595 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bcd9bbe 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9b0a1cf 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 13bbcae 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java
32b7993 
> 
> Diff: https://reviews.apache.org/r/22071/diff/
> 
> 
> Testing
> -------
> 
> New unit tests added ... all existing tests pass.
> 
> Results :
> 
> Tests run: 1635, Failures: 0, Errors: 0, Skipped: 13
> 
> …
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:09.837s
> [INFO] Finished at: Thu May 29 23:54:53 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message