ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 22030: Views : Pass temporal request to view resource provider.
Date Thu, 29 May 2014 19:16:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22030/#review44277
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On May 29, 2014, 6:52 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22030/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 6:52 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5929
>     https://issues.apache.org/jira/browse/AMBARI-5929
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to support something like ...
> 
> {code}
>   /**
>    * Get the {@link TemporalInfo temporal information} for the given property
>    * id for this request, if any.
>    *
>    * @param id the property id
>    * @return the temporal information for the given property id; null if noe exists
>    */
>   public TemporalInfo getTemporalInfo(String id);
> {code}
> 
> for view resource request.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 466ce5a

>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java
e9d2a4c 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 05947d5

>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceProviderTest.java
PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ReadRequest.java ddadd42 
> 
> Diff: https://reviews.apache.org/r/22030/diff/
> 
> 
> Testing
> -------
> 
> New unit tests added.  All existing pass ...
> 
> Results :
> 
> Tests run: 1633, Failures: 0, Errors: 0, Skipped: 13
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:17.828s
> [INFO] Finished at: Thu May 29 14:42:43 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message