ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 21999: Predicates don't work on fields with float values
Date Thu, 29 May 2014 02:20:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/#review44223
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On May 28, 2014, 9:20 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21999/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 9:20 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5922
>     https://issues.apache.org/jira/browse/AMBARI-5922
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> API should be able to process filter with predicates(<,>,=) for fields with float
 values; For example field: metrics/load/load_one.
> 
> Currently the Greater than predicate will fail for values in between 0.0 and 1.0
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java
e8102d6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java
af79eff 
> 
> Diff: https://reviews.apache.org/r/21999/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 207 tests in 0.662s
> 
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message