ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Re: Review Request 21160: Usability: performing connectivity checks against an external database
Date Wed, 28 May 2014 16:10:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------

(Updated May 28, 2014, 4:10 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.


Bugs: AMBARI-5696
    https://issues.apache.org/jira/browse/AMBARI-5696


Repository: ambari


Description
-------

Hive/Oozie (and possibly other components in the future) make use of a relational database
to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC
string. Currently, such mistakes are not caught until service install or start, at which point
it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string,
username, and password, so that the UI can expose this to the end user in the Customize Services
page.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py e96deb5 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py ed74232 
  ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
e5c5ca8 
  ambari-server/src/main/python/ambari-server.py aa183e8 
  ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d

  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py
ff3e818 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py
39eef3b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
2c0d1b1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py
a65473d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java
e3575e1 
  ambari-server/src/test/python/TestAmbariServer.py 3817e91 
  ambari-server/src/test/python/TestCheckHost.py e40dee3 

Diff: https://reviews.apache.org/r/21160/diff/


Testing
-------

Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec

Results :

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Vitalyi Brodetskyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message