ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako" <yus...@hortonworks.com>
Subject Re: Review Request 21803: Integrate Ambari Shell
Date Thu, 22 May 2014 22:57:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21803/#review43788
-----------------------------------------------------------


Thanks for submitting this patch.
Shell/Groovy Client is a great addition to Ambari.

Several issues:

1. python-client fails to build (due to pom.xml) - see my comment on that pom.xml file.

2. ambari-shell fails to build.  pom.xml should be fixed accordingly.

[root@c6401 ambari-shell]# mvn package
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Ambari Shell 1.3.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[WARNING] The POM for org.springframework.shell:spring-shell:jar:1.1.0.RC3 is missing, no
dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.091s
[INFO] Finished at: Thu May 22 22:52:23 UTC 2014
[INFO] Final Memory: 6M/28M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project ambari-shell: Could not resolve dependencies for
project org.apache.ambari:ambari-shell:jar:1.3.0-SNAPSHOT: Failure to find org.springframework.shell:spring-shell:jar:1.1.0.RC3
in http://download.eclipse.org/rt/eclipselink/maven.repo was cached in the local repository,
resolution will not be reattempted until the update interval of EclipseLink has elapsed or
updates are forced -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException




ambari-client/python-client/pom.xml
<https://reviews.apache.org/r/21803/#comment78071>

    This needs to be changed to ../../ambari-client
    Otherwise, mvn commands fail.


- Yusaku Sako


On May 22, 2014, 9:35 a.m., Krisztian Horvath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21803/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 9:35 a.m.)
> 
> 
> Review request for Ambari and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5482
>     https://issues.apache.org/jira/browse/AMBARI-5482
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-5482
> 
> There is an open source effort to implement Ambari-Shell: https://github.com/sequenceiq/ambari-shell
> It would make sense to integrate it into the official source tree
> 
> 
> Diffs
> -----
> 
>   ambari-client/groovy-client/pom.xml PRE-CREATION 
>   ambari-client/groovy-client/src/main/groovy/org/apache/ambari/groovy/client/AmbariClient.groovy
PRE-CREATION 
>   ambari-client/groovy-client/src/main/java/org/apache/ambari/groovy/client/DoNotDeleteMe.java
PRE-CREATION 
>   ambari-client/groovy-client/src/main/resources/blueprints/multi-node-hdfs-yarn PRE-CREATION

>   ambari-client/groovy-client/src/main/resources/blueprints/single-node-hdfs-yarn PRE-CREATION

>   ambari-client/groovy-client/src/test/groovy/com.sequenceiq.ambari.client/AmbariClientTest.groovy
PRE-CREATION 
>   ambari-client/groovy-client/src/test/java/org/apache/ambari/groovy/client/NeitherMe.java
PRE-CREATION 
>   ambari-client/groovy-client/src/test/resources/blueprint.json PRE-CREATION 
>   ambari-client/groovy-client/src/test/resources/blueprints.json PRE-CREATION 
>   ambari-client/groovy-client/src/test/resources/cluster.json PRE-CREATION 
>   ambari-client/groovy-client/src/test/resources/hdfsServiceComponents.json PRE-CREATION

>   ambari-client/groovy-client/src/test/resources/services.json PRE-CREATION 
>   ambari-client/groovy-client/src/test/resources/tasks.json PRE-CREATION 
>   ambari-client/pom.xml 4c6f009 
>   ambari-client/python-client/pom.xml PRE-CREATION 
>   ambari-client/python-client/src/examples/create.py PRE-CREATION 
>   ambari-client/python-client/src/examples/delete.py PRE-CREATION 
>   ambari-client/python-client/src/examples/example.py PRE-CREATION 
>   ambari-client/python-client/src/examples/main.py PRE-CREATION 
>   ambari-client/python-client/src/examples/trial.py PRE-CREATION 
>   ambari-client/python-client/src/main/python/ambari_client/__init__.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/ambari_api.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/core/__init__.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/core/coreutils.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/core/errors.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/core/http_client.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/core/http_utils.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/core/rest_resource.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/__init__.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/base_model.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/cluster.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/component.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/configuration.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/host.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/paths.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/service.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/stack.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/status.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/model/utils.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/resources/__init__.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/resources/clusters.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/resources/hosts.py PRE-CREATION

>   ambari-client/python-client/src/main/python/ambari_client/resources/stacks.py PRE-CREATION

>   ambari-client/python-client/src/main/python/setup.py PRE-CREATION 
>   ambari-client/python-client/src/packages/tarball/all.xml PRE-CREATION 
>   ambari-client/python-client/src/test/python/TestAmbariClient.py PRE-CREATION 
>   ambari-client/python-client/src/test/python/TestClusterModel.py PRE-CREATION 
>   ambari-client/python-client/src/test/python/TestComponentModel.py PRE-CREATION 
>   ambari-client/python-client/src/test/python/TestHostModel.py PRE-CREATION 
>   ambari-client/python-client/src/test/python/TestServiceModel.py PRE-CREATION 
>   ambari-client/python-client/src/test/python/TestStatusModel.py PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/ambariclient_bootstrap_hosts.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/ambariclient_get_all_clusters.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/ambariclient_get_all_hosts.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/ambariclient_get_components.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/ambariclient_get_config.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/ambariclient_get_host.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/clustermodel_error_deleting_host.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/clustermodel_get_all_hosts.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/clustermodel_get_all_services.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/clustermodel_get_cluster.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/clustermodel_get_core_site_config.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/clustermodel_get_global_config.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/clustermodel_get_hdfs_site_config.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/clustermodel_get_host.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/clustermodel_get_mapred_site_config.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/clustermodel_get_service.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/componentmodel_get_metrics.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/get_cluster_service.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/get_components_from_stack.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/get_host_component.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/get_host_components.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/get_service_component.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/get_service_components.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/hostmodel_get_host_component.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/hostmodel_get_host_components.json
PRE-CREATION 
>   ambari-client/python-client/src/test/python/json/servicemodel_get_component.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/servicemodel_get_components.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/status_error_with_message.json PRE-CREATION

>   ambari-client/python-client/src/test/python/json/status_ok_with_id.json PRE-CREATION

>   ambari-client/python-client/src/test/python/unitTests.py PRE-CREATION 
>   ambari-client/python-client/src/test/python/utils/HttpClientInvoker.py PRE-CREATION

>   ambari-client/src/examples/create.py c5f2658 
>   ambari-client/src/examples/delete.py 3debc4c 
>   ambari-client/src/examples/example.py 6702eda 
>   ambari-client/src/examples/main.py 04db4c0 
>   ambari-client/src/examples/trial.py 942236e 
>   ambari-client/src/main/python/ambari_client/__init__.py 278df2e 
>   ambari-client/src/main/python/ambari_client/ambari_api.py daf5e1e 
>   ambari-client/src/main/python/ambari_client/core/__init__.py 278df2e 
>   ambari-client/src/main/python/ambari_client/core/coreutils.py d3e1b4f 
>   ambari-client/src/main/python/ambari_client/core/errors.py c691241 
>   ambari-client/src/main/python/ambari_client/core/http_client.py 484ef5d 
>   ambari-client/src/main/python/ambari_client/core/http_utils.py 07fea45 
>   ambari-client/src/main/python/ambari_client/core/rest_resource.py 532fc53 
>   ambari-client/src/main/python/ambari_client/model/__init__.py 278df2e 
>   ambari-client/src/main/python/ambari_client/model/base_model.py 79fd9ad 
>   ambari-client/src/main/python/ambari_client/model/cluster.py 4a8cce6 
>   ambari-client/src/main/python/ambari_client/model/component.py 586f21a 
>   ambari-client/src/main/python/ambari_client/model/configuration.py 883caf2 
>   ambari-client/src/main/python/ambari_client/model/host.py f261deb 
>   ambari-client/src/main/python/ambari_client/model/paths.py f34c26d 
>   ambari-client/src/main/python/ambari_client/model/service.py ed91d7c 
>   ambari-client/src/main/python/ambari_client/model/stack.py 40088f7 
>   ambari-client/src/main/python/ambari_client/model/status.py f88a534 
>   ambari-client/src/main/python/ambari_client/model/utils.py 0b3b6a0 
>   ambari-client/src/main/python/ambari_client/resources/__init__.py 278df2e 
>   ambari-client/src/main/python/ambari_client/resources/clusters.py ca3cca6 
>   ambari-client/src/main/python/ambari_client/resources/hosts.py 0d53711 
>   ambari-client/src/main/python/ambari_client/resources/stacks.py f4ef518 
>   ambari-client/src/main/python/setup.py 24942ad 
>   ambari-client/src/packages/tarball/all.xml 0e4f34b 
>   ambari-client/src/test/python/TestAmbariClient.py 1831f89 
>   ambari-client/src/test/python/TestClusterModel.py e558706 
>   ambari-client/src/test/python/TestComponentModel.py b3f1530 
>   ambari-client/src/test/python/TestHostModel.py 8b3b531 
>   ambari-client/src/test/python/TestServiceModel.py 6933701 
>   ambari-client/src/test/python/TestStatusModel.py 7f88771 
>   ambari-client/src/test/python/json/ambariclient_bootstrap_hosts.json 1e60bd0 
>   ambari-client/src/test/python/json/ambariclient_get_all_clusters.json abbf619 
>   ambari-client/src/test/python/json/ambariclient_get_all_hosts.json 2aca5c4 
>   ambari-client/src/test/python/json/ambariclient_get_components.json 56bb1b2 
>   ambari-client/src/test/python/json/ambariclient_get_config.json 55f35bc 
>   ambari-client/src/test/python/json/ambariclient_get_host.json d710626 
>   ambari-client/src/test/python/json/clustermodel_error_deleting_host.json 06d1bc9 
>   ambari-client/src/test/python/json/clustermodel_get_all_hosts.json 614f8d4 
>   ambari-client/src/test/python/json/clustermodel_get_all_services.json 53bb2da 
>   ambari-client/src/test/python/json/clustermodel_get_cluster.json 4c72dea 
>   ambari-client/src/test/python/json/clustermodel_get_core_site_config.json 309ba13 
>   ambari-client/src/test/python/json/clustermodel_get_global_config.json 2b7888d 
>   ambari-client/src/test/python/json/clustermodel_get_hdfs_site_config.json 9108aa7 
>   ambari-client/src/test/python/json/clustermodel_get_host.json b1b09d6 
>   ambari-client/src/test/python/json/clustermodel_get_mapred_site_config.json 1080be1

>   ambari-client/src/test/python/json/clustermodel_get_service.json 0c9d5e7 
>   ambari-client/src/test/python/json/componentmodel_get_metrics.json 5623d8b 
>   ambari-client/src/test/python/json/get_cluster_service.json 5b78e05 
>   ambari-client/src/test/python/json/get_components_from_stack.json 55a9c09 
>   ambari-client/src/test/python/json/get_host_component.json 709b94b 
>   ambari-client/src/test/python/json/get_host_components.json 94a3027 
>   ambari-client/src/test/python/json/get_service_component.json 3e993cd 
>   ambari-client/src/test/python/json/get_service_components.json 967bcbd 
>   ambari-client/src/test/python/json/hostmodel_get_host_component.json 436cfda 
>   ambari-client/src/test/python/json/hostmodel_get_host_components.json 8148d18 
>   ambari-client/src/test/python/json/servicemodel_get_component.json c6cbd08 
>   ambari-client/src/test/python/json/servicemodel_get_components.json b9efe73 
>   ambari-client/src/test/python/json/status_error_with_message.json 69ca96d 
>   ambari-client/src/test/python/json/status_ok_with_id.json c805e38 
>   ambari-client/src/test/python/unitTests.py eadfade 
>   ambari-client/src/test/python/utils/HttpClientInvoker.py dd753b2 
>   ambari-project/pom.xml 4f9e9db 
>   ambari-shell/pom.xml PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java PRE-CREATION

>   ambari-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java
PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java PRE-CREATION

>   ambari-shell/src/main/java/org/apache/ambari/shell/commands/ElephantCommand.java PRE-CREATION

>   ambari-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java PRE-CREATION

>   ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java
PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java
PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariBanner.java
PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariPrompt.java
PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/model/AmbariContext.java PRE-CREATION

>   ambari-shell/src/main/java/org/apache/ambari/shell/model/Focus.java PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/model/FocusType.java PRE-CREATION

>   ambari-shell/src/main/java/org/apache/ambari/shell/model/Hints.java PRE-CREATION 
>   ambari-shell/src/main/java/org/apache/ambari/shell/support/TableRenderer.java PRE-CREATION

>   ambari-shell/src/main/resources/elephant.txt PRE-CREATION 
>   ambari-shell/src/test/java/org/apache/ambari/shell/AmbariShellTest.java PRE-CREATION

>   ambari-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java
PRE-CREATION 
>   ambari-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java
PRE-CREATION 
>   ambari-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java PRE-CREATION

>   ambari-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java
PRE-CREATION 
>   ambari-shell/src/test/java/org/apache/ambari/shell/model/AmbariContextTest.java PRE-CREATION

>   ambari-shell/src/test/java/org/apache/ambari/shell/support/TableRendererTest.java PRE-CREATION

>   ambari-shell/src/test/resources/2columns PRE-CREATION 
>   ambari-shell/src/test/resources/3columns PRE-CREATION 
>   ambari-shell/src/test/resources/testBlueprint.json PRE-CREATION 
>   pom.xml 38d0aef 
> 
> Diff: https://reviews.apache.org/r/21803/diff/
> 
> 
> Testing
> -------
> 
> unit tests applied
> 
> 
> Thanks,
> 
> Krisztian Horvath
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message