ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 21810: Provide host specific aggregate metrics on Cluster resource
Date Thu, 22 May 2014 20:00:30 GMT


> On May 22, 2014, 6:05 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java,
lines 1490-1496
> > <https://reviews.apache.org/r/21810/diff/1/?file=588012#file588012line1490>
> >
> >     May not be performant on large clusters.

Agree, but now UI side makes a separate API call to every service host component and agregates
responses by itself. UI shows number of hosts with at least 1 sch in maintenance mode and
with at least 1 sch has staleConfig set to true.

Possibly we have to persist the staleConfig flag, but not calculate it every time when isStaleConfig()
called.


> On May 22, 2014, 6:05 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java,
lines 330-332
> > <https://reviews.apache.org/r/21810/diff/1/?file=588010#file588010line330>
> >
> >     This is not an indicator of passiveness

I had this "case 3" for hosts where nagios can't run check script. For instance, when port
number is None.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21810/#review43739
-----------------------------------------------------------


On May 22, 2014, 2:43 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21810/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 2:43 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5859
>     https://issues.apache.org/jira/browse/AMBARI-5859
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> For 2-node cluster (host 1 is up with no nagios alerts, host 2 is shut down) we will
have:
> 
> Request
> http://localhost:8080/api/v1/clusters/c1?fields=alerts,Clusters/health_report,Clusters/total_hosts
> 
> Response
> {
>   "href" : "http://localhost:8080/api/v1/clusters/c1?fields=alerts,Clusters/health_report,Clusters/total_hosts",
>   "Clusters" : {
>     "cluster_name" : "c1",
>     "health_report" : {
>       "Host/stale_config" : 0,
>       "Host/maintenance_state" : 0,
>       "Host/host_state/HEALTHY" : 1,
>       "Host/host_state/UNHEALTHY" : 0,
>       "Host/host_state/HEARTBEAT_LOST" : 1,
>       "Host/host_state/INIT" : 0,
>       "Host/host_status/HEALTHY" : 1,
>       "Host/host_status/UNHEALTHY" : 0,
>       "Host/host_status/UNKNOWN" : 1,
>       "Host/host_status/ALERT" : 0
>     },
>     "total_hosts" : 2,
>     "version" : "HDP-2.1"
>   },
>   "alerts" : {
>     "summary" : {
>       "CRITICAL" : 1,
>       "OK" : 1,
>       "PASSIVE" : 0,
>       "WARNING" : 0
>     }
>   }
> }  
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java
598958f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
0ff3e62 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
8bd354a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java
a0785f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterHealthReport.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
f0cedb6 
>   ambari-server/src/main/resources/properties.json 0cb32e7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterResponseTest.java
c07a6ed 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
901d55f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java
b0cf585 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
5bc8852 
> 
> Diff: https://reviews.apache.org/r/21810/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [2:30.769s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.416s]
> [INFO] Ambari Web ........................................ SUCCESS [48.519s]
> [INFO] Ambari Views ...................................... SUCCESS [15.913s]
> [INFO] Ambari Server ..................................... SUCCESS [14:39.579s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.413s]
> [INFO] Ambari Client ..................................... SUCCESS [0.537s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message