ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 21824: Service checks should not be hardcoded on the serverside
Date Thu, 22 May 2014 19:44:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21824/#review43756
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
<https://reviews.apache.org/r/21824/#comment78045>

    I'm not sure that service command script was meant to be a service check script, but looks
like we have already started using it in this role (at least at org.apache.ambari.server.controller.AmbariCustomCommandExecutionHelper#addServiceCheckAction
). Not obvious, but fact. Maybe let's add a comment about this usage to org.apache.ambari.server.state.ServiceInfo#commandScript
?



ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java
<https://reviews.apache.org/r/21824/#comment78041>

    This field seems to be unused


Let's also remove hardcoded service check names at Role class. They don't seem to be needed
anymore (maybe in a new jira)

Also, 1 test failed for me for some reason: Failed tests:   testExecuteDMLUpdates(org.apache.ambari.server.upgrade.UpgradeCatalog161Test):
(..)


- Dmitro Lisnichenko


On May 22, 2014, 6:54 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21824/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 6:54 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5861
>     https://issues.apache.org/jira/browse/AMBARI-5861
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently service check actions are hardcoded on the server, so when someone
> tries to add a new service, when running service check, one receives:
> 
>     
>     
>     
>     13:30:09,336 ERROR [qtp1512024071-224] AbstractResourceProvider:244 - Caught AmbariException
when creating a resource
>     org.apache.ambari.server.AmbariException: Unsupported action STORM_SERVICE_CHECK
for STORM
>     
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
b595064 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
8608f5b 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java 41e5034

>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/metainfo.xml 0fe986b 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
1abe4ea 
>   ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
919c32f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
ceda98c 
> 
> Diff: https://reviews.apache.org/r/21824/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message