ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 21566: Agent function get_port_from_url is broken
Date Fri, 16 May 2014 23:23:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21566/#review43285
-----------------------------------------------------------



ambari-agent/src/main/python/resource_management/libraries/functions/get_port_from_url.py
<https://reviews.apache.org/r/21566/#comment77376>

    Why do we need this line? It would return None anyways if nothing found.


- Andrew Onischuk


On May 16, 2014, 7:29 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21566/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 7:29 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-5797
>     https://issues.apache.org/jira/browse/AMBARI-5797
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Pre-1.6.1 had a a function get_port_from_url that was working. In 1.6.1 this
> is broken:
> 
> 1.6.1: uses urlparse function which does not work with a definition like so:
> 0.0.0.0:12345
> 
> 1.6.0: (correctly) uses address.split(':')[-1]
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/libraries/functions/get_port_from_url.py
ce9185b 
>   ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/21566/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message