ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 21485: ambari-server setup command does not return correct exit status upon error
Date Thu, 15 May 2014 11:47:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21485/
-----------------------------------------------------------

(Updated May 15, 2014, 11:47 a.m.)


Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-5740
    https://issues.apache.org/jira/browse/AMBARI-5740


Repository: ambari


Description
-------

As for now, we have following code that run java process:
server_process = subprocess.Popen(param_list, env=environ)
We just create process and ignore any return code of it. Even more, servers java process returns
0(I run command manually with stopped DB) even if some errors happened. It will be more correct
way to make server java process return some return code when problems occurred, and python
part of server pull return code of java process for some small amount of time, and if java
process still alive - report that everything is OK.


Diffs
-----

  ambari-server/src/main/python/ambari-server.py 79c6fc1 
  ambari-server/src/test/python/TestAmbariServer.py 3006a5c 

Diff: https://reviews.apache.org/r/21485/diff/


Testing
-------

As for now, we have following code that run java process:
server_process = subprocess.Popen(param_list, env=environ)
We just create process and ignore any return code of it. Even more, servers java process returns
0(I run command manually with stopped DB) even if some errors happened. It will be more correct
way to make server java process return some return code when problems occurred, and python
part of server pull return code of java process for some small amount of time, and if java
process still alive - report that everything is OK.


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message