ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Review Request 21422: AMBARI-5755. Views: Pig and Files view no longer need to include dependency classes
Date Wed, 14 May 2014 00:50:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21422/
-----------------------------------------------------------

Review request for Ambari and Tom Beerbower.


Bugs: AMBARI-5755
    https://issues.apache.org/jira/browse/AMBARI-5755


Repository: ambari


Description
-------

Views can now include dependencies as jars by including the jars in WEB-INF/lib folder of
the view. 

The Files and Pig views currently do ...

    <descriptorRef>jar-with-dependencies</descriptorRef>

...for the maven assembly plugin in the pom.xml.

This works but includes all of the dependency classes into the view archive including the
ambari-view classes.

Instead of using jar-with-dependencies we should just put the required dependency jars into
the WEB-INF/lib of the view archive. 


Diffs
-----

  contrib/views/files/pom.xml 18232c4 
  contrib/views/pig/pom.xml 4a0b29b 

Diff: https://reviews.apache.org/r/21422/diff/


Testing
-------

build successfully and uploaded the published jar present in the target folder for pig and
files view to the ambari-server host /var/lib/ambari-server/resources/views folder. views
API works.


Thanks,

Jaimin Jetly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message