ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Review Request 21336: remove the property dfs.datanode.du.pct from our configs since it is not being used
Date Tue, 13 May 2014 02:13:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21336/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty and Tom Beerbower.


Bugs: AMBARI-5743
    https://issues.apache.org/jira/browse/AMBARI-5743


Repository: ambari


Description
-------

Based on https://issues.apache.org/jira/browse/HDFS-1564, the HDFS property dfs.datanode.du.pct
is no longer relevent and has been replaced with dfs.datanode.du.reservation. Later HDP stacks
have already removed dfs.datanode.du.pct, but 1.2 through 1.3.3 still referenced it.

I removed dfs.datanode.du.pct from those stacks and verified that dfs.datanode.du.reservation
was set for each of them.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.2.0/services/HDFS/configuration/hdfs-site.xml
db92d4b 
  ambari-server/src/main/resources/stacks/HDP/1.2.1/services/HDFS/configuration/hdfs-site.xml
db92d4b 
  ambari-server/src/main/resources/stacks/HDP/1.3.0/services/HDFS/configuration/hdfs-site.xml
bd978a9 
  ambari-server/src/main/resources/stacks/HDP/1.3.2.GlusterFS/services/GLUSTERFS/configuration/hdfs-site.xml
db92d4b 
  ambari-server/src/main/resources/stacks/HDP/1.3.2.GlusterFS/services/HDFS/configuration/hdfs-site.xml
6246def 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml
f04cfa9 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
fae9ce9 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
96a93c8 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json 880208c 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.json 078f533 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json 0bf5db5

  ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 6c922cf 
  ambari-server/src/test/python/stacks/1.3.2/configs/secured_no_jce_name.json b824d40 
  ambari-server/src/test/resources/api_testscripts/curl-setup-multiple-hbase-master.sh ce9ad45

  ambari-server/src/test/resources/bad-stacks/HDP/0.1/services/HDFS/configuration/hdfs-site.xml
240068b 
  ambari-server/src/test/resources/bad-stacks/HDP/0.1/services/MAPREDUCE/configuration/hdfs-site.xml
240068b 
  ambari-server/src/test/resources/bad-stacks/HDP/0.1/services/MAPREDUCE/configuration/mapred-site.xml
1f3e1a1 
  ambari-server/src/test/resources/deploy_HDP2.sh e378119 
  ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/configuration/hdfs-site.xml
240068b 
  ambari-server/src/test/resources/stacks/HDP/0.1/services/MAPREDUCE/configuration/hdfs-site.xml
240068b 
  ambari-server/src/test/resources/stacks/HDP/0.1/services/MAPREDUCE/configuration/mapred-site.xml
1f3e1a1 
  ambari-server/src/test/resources/stacks/HDP/0.2/services/HDFS/configuration/hdfs-site.xml
240068b 
  ambari-server/src/test/resources/stacks/HDP/0.2/services/MAPREDUCE/configuration/hdfs-site.xml
240068b 
  ambari-server/src/test/resources/stacks/HDP/0.2/services/MAPREDUCE/configuration/mapred-site.xml
1f3e1a1 
  ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HDFS/configuration/hdfs-site.xml
db92d4b 
  ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HDFS/configuration/hdfs-site.xml
2102ddc 
  ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HCFS/configuration/hdfs-site.xml
db92d4b 
  ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HDFS/configuration/hdfs-site.xml
db92d4b 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HDFS/configuration/hdfs-site.xml
e1a244a 

Diff: https://reviews.apache.org/r/21336/diff/


Testing
-------

Ambari Server
================================

Results :

Tests run: 1603, Failures: 0, Errors: 0, Skipped: 10

[INFO] 
[INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-server ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: pass.txt
[INFO] Exclude: derby.log
[INFO] Exclude: src/test/resources/users.ldif
[INFO] Exclude: src/test/resources/gsInstaller-hosts.txt
[INFO] Exclude: src/test/resources/temporal_ganglia_data.txt
[INFO] Exclude: src/test/resources/users.ldif
[INFO] Exclude: src/main/resources/hive-schema-0.10.0.oracle.sql
[INFO] Exclude: src/main/resources/hive-schema-0.12.0.oracle.sql
[INFO] Exclude: src/main/resources/db/serial
[INFO] Exclude: src/main/resources/db/index.txt
[INFO] Exclude: src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/templates/exclude_hosts_list.j2
[INFO] Exclude: conf/unix/ca.config
[INFO] Exclude: conf/unix/krb5JAASLogin.conf
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.sql
[INFO] Exclude: **/*.pydevproject
[INFO] Exclude: src/main/resources/db/newcerts/**
[INFO] Exclude: src/main/resources/stacks/HDP/2.0._/services/HBASE/package/templates/regionservers.j2
[INFO] Exclude: src/test/resources/TestAmbaryServer.samples/**
[INFO] Exclude: src/test/resources/*.txt
[INFO] Exclude: src/test/resources/users_for_dn_with_space.ldif
[INFO] 2680 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 2354 licence.
[INFO] 
[INFO] --- exec-maven-plugin:1.2:exec (python-test) @ ambari-server ---
Test connectivity to hive server
Successfully connected to c6402.ambari.apache.org on port 10000
Test connectivity to hive server
Successfully connected to c6402.ambari.apache.org on port 10000
Test connectivity to hive server
Successfully connected to c6402.ambari.apache.org on port 10000
Test connectivity to hive server
Successfully connected to c6402.ambari.apache.org on port 10000
AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
log
Log not found
log
Cluster primary/cluster OS type is aaa11 and local/current OS type is aaa11
Cluster primary/cluster OS type is zzz_x77 and local/current OS type is ddd33
WARNING: Can not find ambari.properties.rpmsave file from previous version, skipping import
of settings
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:45.949s
[INFO] Finished at: Mon May 12 21:32:55 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------


Python
=====================

----------------------------------------------------------------------
Ran 203 tests in 0.471s

OK
----------------------------------------------------------------------
Total run:550
Total errors:0
Total failures:0


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message