ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 20730: Introduce operation_level request parameter
Date Mon, 05 May 2014 20:06:37 GMT


> On May 5, 2014, 7:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java,
lines 201-238
> > <https://reviews.apache.org/r/20730/diff/5/?file=570689#file570689line201>
> >
> >     Maybe this can be a case statement on Resource.InternalType ?

It's a good idea.


> On May 5, 2014, 7:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java,
lines 78-81
> > <https://reviews.apache.org/r/20730/diff/5/?file=570690#file570690line78>
> >
> >     What is the purpose of keeping these with the level?

Sumit asked to do that for (possible) future use.


> On May 5, 2014, 7:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java,
lines 230-258
> > <https://reviews.apache.org/r/20730/diff/5/?file=570691#file570691line230>
> >
> >     Can a operation level be inferred from the resourceFilter if there is one? 
Is there a relationship that can be exploited?  Seems odd to have a operational level that
does also apply to a resourceFilter

We are going to use resource filter if operation level is not specified explicitly for the
request (as a fallback logic). That is not implemented yet.


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/#review42182
-----------------------------------------------------------


On May 5, 2014, 5:44 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20730/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 5:44 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-5580
>     https://issues.apache.org/jira/browse/AMBARI-5580
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add Requests/operation_level property support and support of subproperties. Possible
"level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed COMPONENT level from
the list of available values, because it seems to be identical to SERVICE level.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java e209076

>   ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 40e9abb

>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 7452a7b

>   ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java
3443b72 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
aefcb52 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
37a404f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
89eaa40 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
de3db69 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java
3b5afcd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
23583b5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
36def40 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java
14f0d55 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
e7098d2 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java
fb4a87a 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql cbf8579 
>   ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2 
>   ambari-server/src/main/resources/properties.json f92d238 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
5ad1e77 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
ff3f08a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
c0ad8ce 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
062338b 
> 
> Diff: https://reviews.apache.org/r/20730/diff/
> 
> 
> Testing
> -------
> 
> I've performed manual testing in various scenarios (Mysql/Oracle DB). I've also tried
to check upgrade from 1.5.x, but it is broken in trunk as of now (created a jira for that).
> Result of unit test run attached.
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 34
licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [2.200s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s]
> [INFO] Ambari Web ........................................ SUCCESS [6.233s]
> [INFO] Ambari Views ...................................... SUCCESS [1.822s]
> [INFO] Ambari Server ..................................... SUCCESS [12:57.429s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.038s]
> [INFO] Ambari Client ..................................... SUCCESS [0.360s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:13.873s
> [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014
> [INFO] Final Memory: 31M/360M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message