ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Review Request 20949: Provide basic validation of fields for blueprint create api
Date Thu, 01 May 2014 14:52:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20949/
-----------------------------------------------------------

Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.


Bugs: AMBARI-5648
    https://issues.apache.org/jira/browse/AMBARI-5648


Repository: ambari


Description
-------

This task is for non topology related validation of blueprint create api calls.
The following validations are included:
no blueprint name
no host groups
no host group name
no host group components
component specified with no name
invalid component name for stack
no/invalid stack name
no/invalid stack version
Validation failures result in a 400 response with a descriptive message of the problem.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java cdb7fea

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
ea2fdec 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
9e12c63 

Diff: https://reviews.apache.org/r/20949/diff/


Testing
-------

Manual Functional Tests:
Tested that appropriate responses were returned for invalid requests.

Unit Tests:
- Added new tests
- All unit tests pass

Results :

Tests run: 1581, Failures: 0, Errors: 0, Skipped: 9
...
Total run:548
Total errors:0
Total failures:0
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:35.082s
[INFO] Finished at: Wed Apr 30 20:53:29 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

John Speidel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message