Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7489267711999135702=="
MIME-Version: 1.0
Subject: Re: Review Request 20327: Allow inline host group scoped
 configuration to be
 specified in Blueprints
From: "Sid Wagle" <swagle@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>, "Sid Wagle" <swagle@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "John Speidel" <jspeidel@hortonworks.com>
Date: Tue, 15 Apr 2014 17:12:04 -0000
Message-ID: <20140415171204.31821.72337@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sid Wagle" <noreply@reviews.apache.org>
References: <20140415165447.14868.27383@reviews.apache.org>
In-Reply-To: <20140415165447.14868.27383@reviews.apache.org>
Reply-To: "Sid Wagle" <swagle@hortonworks.com>

--===============7489267711999135702==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On April 15, 2014, 4:54 p.m., Tom Beerbower wrote:
> > Just a general question for anybody around the upgrade catalog.  What happens if in the next week or so we decide that there needs to be a 1.5.2 release?  Do we just rename this new 160 catalog?

Hi Tom, good question the upgrade path is determined based on version comparison as of now, so rename would be necessary, maybe we should revisit this approach. 


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20327/#review40404
-----------------------------------------------------------


On April 15, 2014, 4:46 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20327/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 4:46 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5462
>     https://issues.apache.org/jira/browse/AMBARI-5462
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow users to specify host group scoped configuration in a blueprint.  This configuration is specified inline within host group definition.
> A subsequent Jira will handle reusable host group scoped configuration that is specified outside of the host group.
> 
> Please see the Apache Jira for more information: https://issues.apache.org/jira/browse/AMBARI-5462
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ee3ff3b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 8d26cfa 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java e817473 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java 7572930 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfiguration.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityPK.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupEntity.java fbc6ef4 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java a3f253f 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java 3566e23 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 41e3127 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5418cac 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c2b0574 
>   ambari-server/src/main/resources/META-INF/persistence.xml 50f1fe0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java fbeecbd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 922df27 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityPKTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20327/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> Used blueprint with host group scoped configuration to create a cluster and ensure that config properties are set properly and visible in UI.
> 
> Unit Tests:
> - Added additional tests
> - All tests pass
> 
> Tests run: 1533, Failures: 0, Errors: 0, Skipped: 9
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:47.035s
> [INFO] Finished at: Mon Apr 14 11:33:55 EDT 2014
> [INFO] Final Memory: 30M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> John Speidel
> 
>


--===============7489267711999135702==--