ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 20501: Caputre all Hive properties in the stack definition
Date Wed, 30 Apr 2014 15:33:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41836
-----------------------------------------------------------


Sid, required property validation in BlueprintResourceProvider is still wrong.  At this point
I would really like to have the changes in BlueprintResourceProvider split out into another
patch so that we can get the base stack changes submitted.


ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
<https://reviews.apache.org/r/20501/#comment75457>

    missing return desription



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment75458>

    should be 'isRequired()'



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment75460>

    javadoc should state that method throws IllegalArgumentException if validation fails.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment75464>

    validation is still incorrect.  If there are host group scoped configurations, validation
needs to be done at the host group level by overlaying the host group configuration over cluster
scoped configurations.  Each host group may contain a different set of configuration properties
and these are specific to the containing host group.  



ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
<https://reviews.apache.org/r/20501/#comment75465>

    should hashCode and equals be updated for new fields?



ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
<https://reviews.apache.org/r/20501/#comment75466>

    what is the default property type?  Every property should now have a type even if it is
a standard property type.  For all standard properties, the default property type should be
used without need of specifying the type in the stack definition.


- John Speidel


On April 29, 2014, 9:41 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 9:41 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to
the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
5fef43a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0

>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
ea2fdec 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
2ca70f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a

>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml
f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml
3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml
6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml
61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
40e4bf3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml
7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message