ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 20785: Ambari REST API: Rename host-groups in cluster create to host_groups for consistency across api
Date Mon, 28 Apr 2014 18:30:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20785/#review41615
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On April 28, 2014, 5:31 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20785/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 5:31 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5597
>     https://issues.apache.org/jira/browse/AMBARI-5597
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The host group field name is inconsistent across the blueprint and the cluster create
body.
> In blueprints it is "host_groups" and in the cluster create call it is "host-groups".
> Change the field name in the cluster create call to "host_groups" as the rest of the
api uses underscore.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
90017ac 
>   ambari-server/src/main/resources/scripts/cluster_blueprint.py ce6780e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
fc08061 
>   ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json 73fd226

> 
> Diff: https://reviews.apache.org/r/20785/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> provisioned a cluster via a blueprint
> 
> Unit Testing:
> All tests passed.
> 
> Tests run: 1570, Failures: 0, Errors: 0, Skipped: 9
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:50.839s
> [INFO] Finished at: Mon Apr 28 11:59:04 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message