ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 20646: Ambari Views : Persistence Data Store
Date Thu, 24 Apr 2014 03:09:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20646/
-----------------------------------------------------------

(Updated April 24, 2014, 3:09 a.m.)


Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-5554
    https://issues.apache.org/jira/browse/AMBARI-5554


Repository: ambari


Description
-------

The view context will expose a data store object with the following interface ...

{code}
public interface DataStore {
 
  public void store(Object entity) throws PersistenceException;

  public void remove(Object entity) throws PersistenceException;
 
  public <T> T find(Class<T> clazz, Object primaryKey) 
    throws PersistenceException;

  public <T> Collection<T> findAll(Class<T> clazz, String whereClause) 
    throws PersistenceException;
}

{code}

This will allow a view to persist any Java Bean as application data.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 86c11cb

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewDAO.java e554973 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java b01ab36

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntityEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
901ce09 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java b0521ee

  ambari-server/src/main/java/org/apache/ambari/server/view/DataStoreImpl.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/view/DataStoreModule.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java e4cc71f 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java a5112e0 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/EntityConfig.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/PersistenceConfig.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
8020bc0 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3e55558 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 816d63c 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql df05fd4 
  ambari-server/src/main/resources/META-INF/persistence.xml aa85db1 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityEntityTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java 9bcf86a

  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
a3de765 
  ambari-server/src/test/java/org/apache/ambari/server/view/DataStoreImplTest.java PRE-CREATION

  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/EntityConfigTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/PersistenceConfigTest.java
PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/DataStore.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/PersistenceException.java PRE-CREATION

  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 8a00d4d 

Diff: https://reviews.apache.org/r/20646/diff/


Testing
-------

Results :

Tests run: 1564, Failures: 0, Errors: 0, Skipped: 9

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:59.834s
[INFO] Finished at: Wed Apr 23 22:44:40 EDT 2014
[INFO] Final Memory: 36M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message