ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 20263: When new host components are created thru API, some indication should be given that Nagios has to be restarted
Date Fri, 18 Apr 2014 15:39:48 GMT


> On April 18, 2014, 3:30 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java,
line 342
> > <https://reviews.apache.org/r/20263/diff/3/?file=562172#file562172line342>
> >
> >     Can we modify an existing HB handler test to assert that restart required flag
is set?

ok


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20263/#review40775
-----------------------------------------------------------


On April 18, 2014, 3:18 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20263/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 3:18 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5445
>     https://issues.apache.org/jira/browse/AMBARI-5445
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Any services with lines below in metainfo.xml will have stale_config == true if any new
host components will be added or deleted.
> <metainfo>
> <service>
> <monitoringService>true</monitoringService>
> </service>
> </metainfo>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 0f284a2

>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
52c7309 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
93b0dca 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
8b29852 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 964d2d6

>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
0938af6 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 39566d9

>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
1d4ae4b 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d04d0b 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ae18892 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be43f1 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/metainfo.xml 528db40

>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/metainfo.xml 74f6c2b

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/metainfo.xml 98703bc

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/metainfo.xml f435f6d

>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
98bc4e8 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/NAGIOS/metainfo.xml 76471cf

> 
> Diff: https://reviews.apache.org/r/20263/diff/
> 
> 
> Testing
> -------
> 
> All service tests passed
> 
> + Tested manually with Postgres, Mysql, Oracle as Ambari DB, because DB schema was updated.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message