ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 20327: Allow inline host group scoped configuration to be specified in Blueprints
Date Tue, 15 Apr 2014 16:46:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20327/
-----------------------------------------------------------

(Updated April 15, 2014, 4:46 p.m.)


Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.


Changes
-------

Addresses comments from reviewers.


Bugs: AMBARI-5462
    https://issues.apache.org/jira/browse/AMBARI-5462


Repository: ambari


Description
-------

Allow users to specify host group scoped configuration in a blueprint.  This configuration
is specified inline within host group definition.
A subsequent Jira will handle reusable host group scoped configuration that is specified outside
of the host group.

Please see the Apache Jira for more information: https://issues.apache.org/jira/browse/AMBARI-5462


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
ee3ff3b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
8d26cfa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
e817473 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java
7572930 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfiguration.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityPK.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupEntity.java fbc6ef4

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java a3f253f

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java 3566e23

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java PRE-CREATION

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 41e3127 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5418cac 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c2b0574 
  ambari-server/src/main/resources/META-INF/persistence.xml 50f1fe0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
fbeecbd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
922df27 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityPKTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/20327/diff/


Testing
-------

Functional Testing:
Used blueprint with host group scoped configuration to create a cluster and ensure that config
properties are set properly and visible in UI.

Unit Tests:
- Added additional tests
- All tests pass

Tests run: 1533, Failures: 0, Errors: 0, Skipped: 9
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:47.035s
[INFO] Finished at: Mon Apr 14 11:33:55 EDT 2014
[INFO] Final Memory: 30M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

John Speidel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message