ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 20356: Flume: add processes endpoint
Date Tue, 15 Apr 2014 09:49:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/#review40375
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java
<https://reviews.apache.org/r/20356/#comment73359>

    Could we avoid this by internally making multiple requests and joining the results if
needed?  


- Tom Beerbower


On April 15, 2014, 3:07 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20356/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 3:07 a.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5467
>     https://issues.apache.org/jira/browse/AMBARI-5467
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Add "processes" endpoint to HostComponents.  This will minimally contain a name and
status property.  This patch seems big, but most changes are just a couple of lines.
> * Also allow agents to write their own information there.  These can be any name and
change from service-to-service.
> * Some flume script changes and fixes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e

>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d

>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java
a0e01f3 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
aeb46e1 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
c0f8297 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
880b13e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49

>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
82ee296 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
ba57a31 
>   ambari-server/src/main/resources/key_properties.json b3715cb 
>   ambari-server/src/main/resources/properties.json a3f4fdd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py
431935b 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
acd401d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df 
> 
> Diff: https://reviews.apache.org/r/20356/diff/
> 
> 
> Testing
> -------
> 
> 
> OK
> ----------------------------------------------------------------------
> Total run:529
> Total errors:0
> Total failures:0
> OK
> AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
> log
> Log not found
> log
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:42.467s
> [INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message