ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev Konar" <maha...@apache.org>
Subject Re: Review Request 20234: storm-env.sh needs to be created at /etc/storm/conf
Date Thu, 10 Apr 2014 22:46:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20234/#review40097
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On April 10, 2014, 9:53 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20234/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 9:53 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Sid Wagle.
> 
> 
> Bugs: Ambari-5431
>     https://issues.apache.org/jira/browse/Ambari-5431
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The problem here is storm topologies cannot be submitted because JAVA_HOME is not defined
on Ambari deployed cluster. Instead of defining JAVA_HOME each time a user submits the topology,
lets add storm-env.sh (similar to hadoop-env.sh) for storm.
> This file is mandatory and has to be present under /etc/storm/conf for Ambari clusters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py
c0f3e18 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/storm.py
bce272b 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/templates/storm-env.sh.j2
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 75ee5e6 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py f5247ac 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py b236083 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 243184f

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 240b39f 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 6e3639c

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 5403ebb 
> 
> Diff: https://reviews.apache.org/r/20234/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:521
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message