ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 20213: Fix BootStrap of Ambari Agents to work on Ubuntu.
Date Thu, 10 Apr 2014 16:00:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20213/#review40018
-----------------------------------------------------------



ambari-server/src/main/python/bootstrap.py
<https://reviews.apache.org/r/20213/#comment72805>

    how about specifying more concrete regexp? Current regexp will match any package that
starts with sudo, e.g. sudoku or sudo-ldap.



ambari-server/src/main/python/setupAgent.py
<https://reviews.apache.org/r/20213/#comment72807>

    maybe change to "Version\:" to avoid surprises with changed package description in future?



ambari-server/src/main/python/setupAgent.py
<https://reviews.apache.org/r/20213/#comment72808>

    maybe change to "Version\:" to avoid surprises with changed package description in future?



ambari-server/src/main/python/setupAgent.py
<https://reviews.apache.org/r/20213/#comment72809>

    why do we use docstring here?



ambari-server/src/test/python/TestSetupAgent.py
<https://reviews.apache.org/r/20213/#comment72810>

    maybe also add is_debian() mock?



ambari-server/src/test/python/TestSetupAgent.py
<https://reviews.apache.org/r/20213/#comment72811>

    maybe also add is_debian() mock?



ambari-server/src/test/python/TestSetupAgent.py
<https://reviews.apache.org/r/20213/#comment72812>

    How about Debian?


- Dmitro Lisnichenko


On April 10, 2014, 2:47 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20213/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 2:47 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5424
>     https://issues.apache.org/jira/browse/AMBARI-5424
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix BootStrap of Ambari Agents to work on Ubuntu.
> Need to make sure the bootstrap of agent works all fine.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
f62bfd0 
>   ambari-server/src/main/python/bootstrap.py 908451e 
>   ambari-server/src/main/python/setupAgent.py 69f357a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
c76ab46 
>   ambari-server/src/test/python/TestBootstrap.py 88ff3c2 
>   ambari-server/src/test/python/TestSetupAgent.py b9c6056 
> 
> Diff: https://reviews.apache.org/r/20213/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [1.420s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.229s]
> [INFO] Ambari Web ........................................ SUCCESS [10.746s]
> [INFO] Ambari Views ...................................... SUCCESS [1.556s]
> [INFO] Ambari Server ..................................... SUCCESS [12:38.536s]
> [INFO] Ambari Agent ...................................... SUCCESS [36.633s]
> [INFO] Ambari Client ..................................... SUCCESS [0.888s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message