ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 20108: Ambari Views : MySQL create script is wrong for View tables
Date Mon, 07 Apr 2014 23:12:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20108/#review39740
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On April 7, 2014, 10:45 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20108/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 10:45 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-5385
>     https://issues.apache.org/jira/browse/AMBARI-5385
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The create table statements for views should not include 'ambari'...
> {code}
> CREATE TABLE ambari.viewmain (view_name VARCHAR(255) NOT NULL, label VARCHAR(255), version
VARCHAR(255), archive VARCHAR(255), PRIMARY KEY(view_name));
> {code}
> Should be ...
> {code}
> CREATE TABLE viewmain (view_name VARCHAR(255) NOT NULL, label VARCHAR(255), version VARCHAR(255),
archive VARCHAR(255), PRIMARY KEY(view_name));
> {code}
> 
> Also, remove the GRANT ALL statements for the view tables ... 
> 
> {code}
> GRANT ALL PRIVILEGES ON TABLE ambari.view TO :username;
> {code} 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7db8b80 
> 
> Diff: https://reviews.apache.org/r/20108/diff/
> 
> 
> Testing
> -------
> 
> Results :
> 
> Tests run: 1519, Failures: 0, Errors: 0, Skipped: 9
> 
> 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:14.394s
> [INFO] Finished at: Mon Apr 07 18:16:46 EDT 2014
> [INFO] Final Memory: 36M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message