ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Re: Review Request 20013: Ambari hiveserver2 smoke test wrong for hiveserver 2 that uses LDAP authentication
Date Thu, 03 Apr 2014 18:10:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20013/
-----------------------------------------------------------

(Updated April 3, 2014, 6:10 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.


Bugs: AMBARI-5343
    https://issues.apache.org/jira/browse/AMBARI-5343


Repository: ambari


Description
-------

PROBLEM:

from /tmp/hiveserver2Smoke.sh


smokeout=`/usr/lib/hive/bin/beeline -u $1 -n fakeuser -p fakepwd -d org.apache.hive.jdbc.HiveDriver
-e '!run $2' 
2>&1| awk '{print}'|grep Error`

if [ "x$smokeout" == "x" ]; then
  echo "Smoke test of hiveserver2 passed"
  exit 0
else
  echo "Smoke test of hiveserver2 wasnt passed"
  echo $smokeout
  exit 1
fi


Few errors in this script:

1. for LDAP authentication, it requires a real user and password
2. LDAP authentication may hang, not generating 'Error' string. The script will not detect
the failure.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/service_check.py
111e8a1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/service_check.py
111e8a1 
  ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_service_check.py f1deec7 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 6390a70 

Diff: https://reviews.apache.org/r/20013/diff/


Testing
-------

----------------------------------------------------------------------
Ran 191 tests in 1.418s

OK
----------------------------------------------------------------------
Total run:521
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message