ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 19959: Ambari Views : need to add view tables for upgrade catalog
Date Wed, 02 Apr 2014 23:33:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19959/
-----------------------------------------------------------

(Updated April 2, 2014, 11:33 p.m.)


Review request for Ambari, Nate Cole and Sid Wagle.


Changes
-------

Made the view FK constraint names shorter for the Oracle limit and made the column viewmain.lable
nullable, as Sid suggested.


Bugs: AMBARI-5329
    https://issues.apache.org/jira/browse/AMBARI-5329


Repository: ambari


Description
-------


Need to add an UpgradeCatalog151 to add the new tables during upgrade. getTargetVersion()
should return "1.5.1"

see View Tables in create DDL ...
ambari.viewmain
ambari.viewinstancedata
ambari.viewinstance
ambari.viewinstanceproperty
ambari.viewparameter
ambari.viewresource


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 6065d95

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java PRE-CREATION

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 44fdb1a 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql fbcc219 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4b96984 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/19959/diff/


Testing
-------

Results :

Tests run: 1518, Failures: 0, Errors: 0, Skipped: 10

...
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:00.132s
[INFO] Finished at: Wed Apr 02 16:31:52 EDT 2014
[INFO] Final Memory: 35M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message