Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B8CCD106CE for ; Wed, 26 Mar 2014 13:57:34 +0000 (UTC) Received: (qmail 51347 invoked by uid 500); 26 Mar 2014 13:57:29 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 51254 invoked by uid 500); 26 Mar 2014 13:57:28 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 51111 invoked by uid 99); 26 Mar 2014 13:57:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Mar 2014 13:57:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A91F71D5AF4; Wed, 26 Mar 2014 13:57:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1384299823450309256==" MIME-Version: 1.0 Subject: Review Request 19682: hive-env.sh overwrites user value of HIVE_AUX_JARS_PATH From: "Vitalyi Brodetskyi" To: "Mahadev Konar" , "Dmitro Lisnichenko" Cc: "Vitalyi Brodetskyi" , "Ambari" Date: Wed, 26 Mar 2014 13:57:14 -0000 Message-ID: <20140326135714.4904.64234@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vitalyi Brodetskyi" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/19682/ X-Sender: "Vitalyi Brodetskyi" Reply-To: "Vitalyi Brodetskyi" X-ReviewRequest-Repository: ambari --===============1384299823450309256== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19682/ ----------------------------------------------------------- Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar. Bugs: AMBARI-5223 https://issues.apache.org/jira/browse/AMBARI-5223 Repository: ambari Description ------- This line at the bottom of {{hive-env.sh}} disregards any user-provided values, masking them from the launch script. {noformat} # Folder containing extra ibraries required for hive compilation/execution can be controlled by: export HIVE_AUX_JARS_PATH=/usr/lib/hcatalog/share/hcatalog/hcatalog-core.jar {noformat} This breaks this feature for users of both the environment {{export HIVE_AUX_JARS_PATH="my custom value"}} and the command line {{hive --auxpath "my custom value"}} . Diffs ----- ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/templates/hive-env.sh.j2 548262a ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/hive-env.sh.j2 61f8a60 Diff: https://reviews.apache.org/r/19682/diff/ Testing ------- Thanks, Vitalyi Brodetskyi --===============1384299823450309256==--