Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38B82105DA for ; Tue, 25 Mar 2014 17:05:16 +0000 (UTC) Received: (qmail 66385 invoked by uid 500); 25 Mar 2014 17:05:15 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 66351 invoked by uid 500); 25 Mar 2014 17:05:13 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 66338 invoked by uid 99); 25 Mar 2014 17:05:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Mar 2014 17:05:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5A781D5959; Tue, 25 Mar 2014 17:05:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6373259018545718137==" MIME-Version: 1.0 Subject: Re: Review Request 19615: Alert display randomly shows "No alerts" and then populate with alerts, back and forth From: "Sid Wagle" To: "Sid Wagle" , "Tom Beerbower" Cc: "Nate Cole" , "Ambari" Date: Tue, 25 Mar 2014 17:05:09 -0000 Message-ID: <20140325170509.8474.81667@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sid Wagle" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/19615/ X-Sender: "Sid Wagle" References: <20140325151150.8507.79812@reviews.apache.org> In-Reply-To: <20140325151150.8507.79812@reviews.apache.org> Reply-To: "Sid Wagle" X-ReviewRequest-Repository: ambari --===============6373259018545718137== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19615/#review38453 ----------------------------------------------------------- Ship it! Ship It! - Sid Wagle On March 25, 2014, 3:11 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19615/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 3:11 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-5201 > https://issues.apache.org/jira/browse/AMBARI-5201 > > > Repository: ambari > > > Description > ------- > > Service alerts show "No alerts" then actual alerts, then "No alerts", back and forth. This was observed on a 800-node cluster. > > The issue is that on large clusters, the call to retrieve Nagios alerts takes a long time, and eventually times out. The fix is to make the call asynchronous so as not to block the UI. The reason for Nagios timeout is another issue. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/AlertState.java 929d0bc > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 4dc8f16 > > Diff: https://reviews.apache.org/r/19615/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up JAVA_TOOL_OPTIONS: -Dapple.awt.UIElement=true > Running org.apache.ambari.server.controller.nagios.NagiosPropertyProviderTest > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.91 sec > > Results : > > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Nate Cole > > --===============6373259018545718137==--