Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6996912652310827120=="
MIME-Version: 1.0
Subject: Re: Review Request 19541: Host registering failure from primary/agent
 os
 checking on centos6
From: "Andrew Onischuk" <aonishuk@hortonworks.com>
To: "Dmytro Sen" <dsen@hortonworks.com>
Cc: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Mon, 24 Mar 2014 11:00:31 -0000
Message-ID: <20140324110031.25880.65727@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Andrew Onischuk" <noreply@reviews.apache.org>
References: <20140324105743.25880.40649@reviews.apache.org>
In-Reply-To: <20140324105743.25880.40649@reviews.apache.org>
Reply-To: "Andrew Onischuk" <aonishuk@hortonworks.com>

--===============6996912652310827120==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19541/
-----------------------------------------------------------

(Updated March 24, 2014, 11 a.m.)


Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-4523
    https://issues.apache.org/jira/browse/AMBARI-4523


Repository: ambari


Description
-------

I am using Ambari (1.4.3.38) for hadoop cluster installation and management. All the cluster nodes are built on centos 6.0.

During the ambari server installation, ambari-server recognized the primary/cluster os as redhat6 (see ambari.properties). 
During the ambari agent bootstrap/host register, ambari-agent regonized the agent os as centos linux6 (see log). 

>From log files (ambari-server.log, ambari-agent.log), I found the inconsistence caused the warning of ambari-agent bootstrapping and failure of host registering.

I'm still not sure why this happen, but I guess it's caused by the differene of os checking methods among ambari server side code, ambari-agent bootstrap script (os_type_check.sh,based on os release file) and registering script (Controller.py/Register.py based on os hardware profile) .

I just share to see if anyone can fix the issue.

BTW, for me, to solve the problem, I manually edited the script files to make it work temporarily:

To avoid warning of agent bootstrapping, in os_type_check.sh, add current_os=$RH6 above the echo line or add res=0 after case statement;
To make the node register work, in Controller.py, add data=data.replace('centos linux','redhat') before sending registering request;

Thanks.


Diffs (updated)
-----

  ambari-agent/pom.xml 352789a 
  ambari-agent/src/main/python/ambari_agent/Facter.py 181f370 
  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 83429de 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py bdfc587 
  ambari-agent/src/main/python/resource_management/core/system.py a3e61b3 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 987308e 
  ambari-common/src/main/python/common_functions/__init__.py PRE-CREATION 
  ambari-common/src/main/python/common_functions/os_check.py PRE-CREATION 
  ambari-server/pom.xml c536b96 
  ambari-server/src/main/python/ambari-server.py 5cec271 
  ambari-server/src/main/python/bootstrap.py 9b4140d 
  ambari-server/src/main/python/os_type_check.sh 83e64d1 
  ambari-server/src/test/python/TestBootstrap.py 9a80213 

Diff: https://reviews.apache.org/r/19541/diff/


Testing
-------

mvn test fine


Thanks,

Andrew Onischuk


--===============6996912652310827120==--