Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3790174524995773711=="
MIME-Version: 1.0
Subject: Re: Review Request 19535: After upgrade hdfs-site and other configs
 don't
 contain properties intoduced in 1.5.0
From: "Mahadev Konar" <mahadev@apache.org>
To: "Mahadev Konar" <mahadev@apache.org>
Cc: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Fri, 21 Mar 2014 21:52:45 -0000
Message-ID: <20140321215245.2925.61456@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Mahadev Konar" <noreply@reviews.apache.org>
References: <20140321215121.2926.33263@reviews.apache.org>
In-Reply-To: <20140321215121.2926.33263@reviews.apache.org>
Reply-To: "Mahadev Konar" <mahadev@apache.org>

--===============3790174524995773711==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19535/#review38217
-----------------------------------------------------------

Ship it!


To sumit's point - this is mostly needed only for YARN for upgrade as of now. The others should be fine since we already add them. We should probably look at a generic way of adding missing configs or removing them.

- Mahadev Konar


On March 21, 2014, 9:51 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19535/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 9:51 p.m.)
> 
> 
> Review request for Ambari and Mahadev Konar.
> 
> 
> Bugs: AMBARI-5178
>     https://issues.apache.org/jira/browse/AMBARI-5178
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari 1.5.0 assumes that existing configs contain properties, introduced in
> 1.5.0 For example, Log message
> 
>     
>       File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py", line 75, in __getattr__
>         raise Fail("Configuration parameter '"+self.name+"' was not found in configurations dictionary!")
>     Fail: Configuration parameter 'yarn.resourcemanager.nodes.exclude-path' was not found in configurations dictionary!
>     
> 
> Bacause params.py for YARN contains
> 
>     
>     rm_nodes_exclude_path = config['configurations']['yarn-site']['yarn.resourcemanager.nodes.exclude-path']
>     
> 
> same for other services
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py f999683 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py a523a4f 
> 
> Diff: https://reviews.apache.org/r/19535/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


--===============3790174524995773711==--