Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5598988602872839294=="
MIME-Version: 1.0
Subject: Re: Review Request 19185: Rolling restart should also handle clients
 on the
 same machine as the restarting component
From: "Sumit Mohanty" <smohanty@hortonworks.com>
To: "Sid Wagle" <swagle@hortonworks.com>
Cc: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Fri, 14 Mar 2014 16:34:58 -0000
Message-ID: <20140314163458.30664.78878@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sumit Mohanty" <noreply@reviews.apache.org>
References: <20140314145622.30664.11280@reviews.apache.org>
In-Reply-To: <20140314145622.30664.11280@reviews.apache.org>
Reply-To: "Sumit Mohanty" <smohanty@hortonworks.com>

--===============5598988602872839294==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19185/#review37213
-----------------------------------------------------------


Dmytro Sen, why would the command['configurationTags'] be None?

- Sumit Mohanty


On March 14, 2014, 2:56 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19185/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 2:56 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-5065
>     https://issues.apache.org/jira/browse/AMBARI-5065
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 3-host cluster, c6401 has nn, c6402 and c6403 have datanodes + hdfs clients
> 1. create host group in Hdfs
> 2. put one host in the group (say c6403) that has datanode and hdfs client
> 3. change datanode max java heap size so it only affects the datanode
> 4. you'll see a restart is needed only on c6403 as expected (correct) for datanode and hdfs client
> 5. Issue a rolling restart and only on hosts that need configs (so just one host)
> 6. the works fine and it only restarts datanode c6403 as expected (correct)
> problem: hdfs client is not marked as restarted so i still see "1 HDFS Client" component requiring a restart on that host.
> Need to handle clients on the machines as well as part of rolling restart.
> Solution:
> Update client tags on Master/Slave component update in-memory and in individual files.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 549651a 
>   ambari-agent/src/main/python/ambari_agent/ActualConfigHandler.py 024c575 
>   ambari-agent/src/main/python/ambari_agent/LiveStatus.py 6f9f4db 
>   ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py e62dd1a 
>   ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 96a21b9 
> 
> Diff: https://reviews.apache.org/r/19185/diff/
> 
> 
> Testing
> -------
> 
> Ran 284 tests in 11.538s
> 
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


--===============5598988602872839294==--