Return-Path: 
 <dev-return-25364-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 71CFDC40E
	for <apmail-ambari-dev-archive@www.apache.org>;
 Wed, 12 Mar 2014 17:04:59 +0000 (UTC)
Received: (qmail 47659 invoked by uid 500); 12 Mar 2014 17:04:58 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 47598 invoked by uid 500); 12 Mar 2014 17:04:58 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 47582 invoked by uid 99); 12 Mar 2014 17:04:57 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Mar 2014 17:04:57 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 2FD881D50CE;
	Wed, 12 Mar 2014 17:04:55 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============1840817252896416691=="
MIME-Version: 1.0
Subject: Re: Review Request 19129: Proxied API requests do not return error
 details
From: "Nate Cole" <ncole@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
Cc: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Wed, 12 Mar 2014 17:04:55 -0000
Message-ID: <20140312170455.22644.45554@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/19129/
X-Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20140312162758.13791.36038@reviews.apache.org>
In-Reply-To: <20140312162758.13791.36038@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============1840817252896416691==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19129/#review36932
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On March 12, 2014, 12:27 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19129/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 12:27 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-5052
>     https://issues.apache.org/jira/browse/AMBARI-5052
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When invoking Falcon API directly, error messages are returned in the body.
> {code}
> [falcon@c6402 tmp]$ curl -i -uadmin:admin -d @dummy.xml -H 'Content-Type: text/xml' -X POST 'http://c6402.ambari.apache.org:15000/api/entities/submit/cluster?user.name=ambari-qa'
> HTTP/1.1 400 Bad Request
> Set-Cookie: hadoop.auth=u=ambari-qa&p=ambari-qa&t=simple&e=1394198276685&s=1Vktza5jyxYPcrpJVSDvok3lriQ=; Path=/; Expires=Fri, 07-Mar-2014 13:17:56 GMT; HttpOnly
> Content-Type: text/xml
> Content-Length: 307
> Server: Jetty(6.1.26)
> 
> <?xml version="1.0" encoding="UTF-8" standalone="yes"?><result><status>FAILED</status><message>Invalid storage server or port: http://c6402.ambari.apache.org:11000/oozi
> Exception creating FileSystem:No FileSystem for scheme: http</message><requestId>ec86dfbf-4e84-4909-8452-041c3c3f36c7</requestId></result>
> {code}
> 
> When going through Ambari proxy, it only returns 400 Bad Request.
> {code}
> curl -i -uadmin:admin -d @dummy.xml -H 'Content-Type: text/xml' -X POST 'http://c6401.ambari.apache.org:8080/proxy?url=http://c6402.ambari.apache.org:15000/api/entities/submit/cluster?user.name=ambari-qa'
> HTTP/1.1 400 Bad Request
> Set-Cookie: AMBARISESSIONID=ypwgf9i05mrjajjcn0gk9gu1;Path=/
> Content-Type: text/plain;charset=ISO-8859-1
> Content-Length: 47
> Server: Jetty(7.6.7.v20120910)
> 
> {
>   "status": 400,
>   "message": "Bad Request"
> }
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java cb07a0b 
>   ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java 9b824fd 
> 
> Diff: https://reviews.apache.org/r/19129/diff/
> 
> 
> Testing
> -------
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Listening for transport dt_socket at address: 5007
> Running org.apache.ambari.server.proxy.ProxyServiceTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 89.416 sec
> 
> Results :
> 
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


--===============1840817252896416691==--