Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 339D710DC4 for ; Mon, 10 Mar 2014 22:09:44 +0000 (UTC) Received: (qmail 51647 invoked by uid 500); 10 Mar 2014 22:09:43 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 51625 invoked by uid 500); 10 Mar 2014 22:09:43 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 51614 invoked by uid 99); 10 Mar 2014 22:09:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Mar 2014 22:09:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A84AB1D4EB3; Mon, 10 Mar 2014 22:09:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0262456132765165959==" MIME-Version: 1.0 Subject: Re: Review Request 18981: API call to get host status takes 30 seconds From: "Tom Beerbower" To: "Sumit Mohanty" , "Tom Beerbower" Cc: "Sid Wagle" , "Ambari" Date: Mon, 10 Mar 2014 22:09:40 -0000 Message-ID: <20140310220940.13497.78850@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/18981/ X-Sender: "Tom Beerbower" References: <20140310205447.27073.25933@reviews.apache.org> In-Reply-To: <20140310205447.27073.25933@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============0262456132765165959== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18981/#review36714 ----------------------------------------------------------- Quick question. It's not clear to me where the issue was and what the fix is. Could you summarize the fix? - Tom Beerbower On March 10, 2014, 8:54 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18981/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 8:54 p.m.) > > > Review request for Ambari, Sumit Mohanty and Tom Beerbower. > > > Bugs: AMBARI-5005 > https://issues.apache.org/jira/browse/AMBARI-5005 > > > Repository: ambari > > > Description > ------- > > [root@perf800-large1 ~]# time curl -u admin:admin 'http://:8080/api/v1/clusters/c1/hosts?fields=Hosts/host_status,Hosts/maintenance_state,host_components/HostRoles/state,host_components/HostRoles/maintenance_state,alerts/summary&minimal_response=true&_=1393982657484' > /dev/null > % Total % Received % Xferd Average Speed Time Time Time Current > Dload Upload Total Spent Left Speed > 100 739k 0 739k 0 0 40120 0 --:--:-- 0:00:18 --:--:-- 191k > > real 0m18.878s > user 0m0.020s > sys 0m0.000s > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java b0258a4 > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 69b58f7 > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 2b30b9f > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 9226cf1 > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 24e5b1a > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java d151e8b > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java c99bfa1 > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3c1632c > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 2cc1165 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java 049af58 > > Diff: https://reviews.apache.org/r/18981/diff/ > > > Testing > ------- > > Results : > > Tests run: 1480, Failures: 0, Errors: 0, Skipped: 9 > > > Thanks, > > Sid Wagle > > --===============0262456132765165959==--