Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF80310C36 for ; Wed, 5 Mar 2014 15:03:47 +0000 (UTC) Received: (qmail 16978 invoked by uid 500); 5 Mar 2014 15:03:47 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 16795 invoked by uid 500); 5 Mar 2014 15:03:44 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 16541 invoked by uid 99); 5 Mar 2014 15:03:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Mar 2014 15:03:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D16CD1D44CF; Wed, 5 Mar 2014 15:03:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7029932814448478678==" MIME-Version: 1.0 Subject: Re: Review Request 18732: [BUG-13267] Provide deb packages for Ambari server and Agents From: "Dmitro Lisnichenko" To: "Andrew Onischuk" , "Sid Wagle" , "Dmitro Lisnichenko" Cc: "Vitaliy Semenyk" , "Ambari" Date: Wed, 05 Mar 2014 15:03:40 -0000 Message-ID: <20140305150340.6955.42845@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/18732/ X-Sender: "Dmitro Lisnichenko" References: <20140305132153.6955.84925@reviews.apache.org> In-Reply-To: <20140305132153.6955.84925@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============7029932814448478678== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18732/#review36225 ----------------------------------------------------------- ambari-agent/src/main/package/deb/control/control New file has no apache license prefix, mvn rat will fail. Please add header to all new files pom.xml Not sure that "development" section is relevant. How about universe/admin or universe/java (zookeeper is located here) pom.xml deb.section repeated twice pom.xml Lets consider switching to unix-maven-plugin http://mojo.codehaus.org/unix/unix-handbook/handbook.html#about-the-plugin . It's said to support deb, pkg and rpm formats. Using different plugins for rpm and deb (with different configurations and different shell scripts) may be highly error-prone and hard to maintain. - Dmitro Lisnichenko On March 5, 2014, 1:21 p.m., Vitaliy Semenyk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18732/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 1:21 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle. > > > Bugs: AMBARI-4934 > https://issues.apache.org/jira/browse/AMBARI-4934 > > > Repository: ambari > > > Description > ------- > > Patch added: > pom.xml: > - new package goal "jdeb", which allows to build deb packages > - "deb.*" properties > - maven-resources-plugin for /usr/sbin/ambari-[agent|server] and version files (jdeb supports only control files filtering) > general: > - debian control files (src/main/package/deb/control/*) and updated for Debian platform post-installation, pre-installation scripts > > Build command example: mvn package jdeb:jdeb > > > Diffs > ----- > > .gitignore 246e53e > ambari-agent/pom.xml 600d17d > ambari-agent/src/main/package/deb/control/control PRE-CREATION > ambari-agent/src/main/package/deb/control/postinst PRE-CREATION > ambari-agent/src/main/package/deb/control/postrm PRE-CREATION > ambari-agent/src/main/package/deb/control/posttrm PRE-CREATION > ambari-agent/src/main/package/deb/control/preinst PRE-CREATION > ambari-agent/src/main/package/deb/control/prerm PRE-CREATION > ambari-client/pom.xml 1bd4c84 > ambari-client/src/main/package/deb/control/control PRE-CREATION > ambari-client/src/main/package/deb/control/postinst PRE-CREATION > ambari-client/src/main/package/deb/control/postrm PRE-CREATION > ambari-client/src/main/package/deb/control/posttrm PRE-CREATION > ambari-client/src/main/package/deb/control/preinst PRE-CREATION > ambari-client/src/main/package/deb/control/prerm PRE-CREATION > ambari-project/pom.xml 426a074 > ambari-project/src/main/package/deb/control/control PRE-CREATION > ambari-project/src/main/package/deb/control/postinst PRE-CREATION > ambari-project/src/main/package/deb/control/postrm PRE-CREATION > ambari-project/src/main/package/deb/control/posttrm PRE-CREATION > ambari-project/src/main/package/deb/control/preinst PRE-CREATION > ambari-project/src/main/package/deb/control/prerm PRE-CREATION > ambari-server/pom.xml 0da58d1 > ambari-server/src/main/package/deb/control/control PRE-CREATION > ambari-server/src/main/package/deb/control/postinst PRE-CREATION > ambari-server/src/main/package/deb/control/postrm PRE-CREATION > ambari-server/src/main/package/deb/control/posttrm PRE-CREATION > ambari-server/src/main/package/deb/control/preinst PRE-CREATION > ambari-server/src/main/package/deb/control/prerm PRE-CREATION > ambari-views/pom.xml 5adc775 > ambari-views/src/main/package/deb/control/control PRE-CREATION > ambari-views/src/main/package/deb/control/postinst PRE-CREATION > ambari-views/src/main/package/deb/control/postrm PRE-CREATION > ambari-views/src/main/package/deb/control/posttrm PRE-CREATION > ambari-views/src/main/package/deb/control/preinst PRE-CREATION > ambari-views/src/main/package/deb/control/prerm PRE-CREATION > ambari-web/pom.xml c01d558 > ambari-web/src/main/assemblies/empty.xml PRE-CREATION > ambari-web/src/main/package/deb/control/control PRE-CREATION > ambari-web/src/main/package/deb/control/postinst PRE-CREATION > ambari-web/src/main/package/deb/control/postrm PRE-CREATION > ambari-web/src/main/package/deb/control/posttrm PRE-CREATION > ambari-web/src/main/package/deb/control/preinst PRE-CREATION > ambari-web/src/main/package/deb/control/prerm PRE-CREATION > pom.xml 33948b2 > src/main/assemblies/empty.xml PRE-CREATION > src/main/package/deb/control/control PRE-CREATION > src/main/package/deb/control/postinst PRE-CREATION > src/main/package/deb/control/postrm PRE-CREATION > src/main/package/deb/control/posttrm PRE-CREATION > src/main/package/deb/control/preinst PRE-CREATION > src/main/package/deb/control/prerm PRE-CREATION > > Diff: https://reviews.apache.org/r/18732/diff/ > > > Testing > ------- > > was changed pom.xml files and bash scripts so unit-test are not required > > > Thanks, > > Vitaliy Semenyk > > --===============7029932814448478678==--