ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 19768: Ambari Views : Persistence
Date Fri, 28 Mar 2014 10:34:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19768/
-----------------------------------------------------------

(Updated March 28, 2014, 10:34 a.m.)


Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-5257
    https://issues.apache.org/jira/browse/AMBARI-5257


Repository: ambari


Description
-------

View Persistence

1. Save view and view instance resources to Ambari DB.
Same as any other resource (Cluster, Service, Blueprint, etc.).  Will use established JPA
patterns to persist resources to Ambari DB.

2. Allow views to store application data in Ambari DB.


Application data map.
Allow application code to store key / value pairs for a view instance.  These are different
than view instance properties in that they may change (updated during the life of the view
instance).  We limit the type to String.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewExternalSubResourceService.java
7ce8b97 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java
f0c32bf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java afc3097

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
d0901e8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
b643773 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewDAO.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceDataEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceDataEntityPK.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityPK.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstancePropertyEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstancePropertyEntityPK.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewParameterEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewParameterEntityPK.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewResourceEntity.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewResourceEntityPK.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 3e1d1a9 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java cc2ec5d 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewExternalSubResourceProvider.java
d3371b6 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java 42b4f4e

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java 9cb889a

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java abeff05 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java
ac7f091 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java 4241e8f

  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ResourceConfig.java
5d23081 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
829e08a 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql da109cf 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 38cc3d7 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 62129b5 
  ambari-server/src/main/resources/META-INF/persistence.xml 5148e63 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewExternalSubResourceServiceTest.java
40ae816 
  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java PRE-CREATION

  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java d0b28c5

  ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java 0aa2a08

  ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java
22652aa 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 2820ef9

  ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java
5b1b4d3 
  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java cd684c3 

Diff: https://reviews.apache.org/r/19768/diff/


Testing
-------

Added new unit tests.

Results :

Tests run: 1511, Failures: 0, Errors: 0, Skipped: 10


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:22.156s
[INFO] Finished at: Thu Mar 27 20:51:27 EDT 2014
[INFO] Final Memory: 35M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message